mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
	netdev@vger.kernel.org,  linux-kernel@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	 Frederic Weisbecker <frederic@kernel.org>,
	Valentin Schneider <vschneid@redhat.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next] net/core/dev.c: enable timestamp static key if CPU isolation is configured
Date: Tue, 27 Feb 2024 09:36:22 +0100	[thread overview]
Message-ID: <35ba7c2cb75bb8141eb518c764ad8975054f0463.camel@redhat.com> (raw)
In-Reply-To: <ZdeSHbRa3rtHE+2E@tpad>

Hi,

On Thu, 2024-02-22 at 15:27 -0300, Marcelo Tosatti wrote:
> For systems that use CPU isolation (via nohz_full), creating or destroying
> a socket with  timestamping (SOF_TIMESTAMPING_OPT_TX_SWHW) might cause a
> static key to be enabled/disabled. This in turn causes undesired
> IPIs to isolated CPUs.

I believe Willem is correct, the relevant flag is
SOF_TIMESTAMPING_RX_SOFTWARE, see:

https://elixir.bootlin.com/linux/v6.8-rc5/source/net/core/sock.c#L938

the example you used is a sort of API misuse, placing flag where a bool
is expected. 

Please send a v2 with the updated commit message, you can mention both
SO_TIMESTAMPING (SOF_TIMESTAMPING_RX_SOFTWARE) and SO_TIMESTAMP.

Please also include Willem in recipients list, since he gave feedback
on previous version.

Thanks!

Paolo


      reply	other threads:[~2024-02-27  8:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 18:27 Marcelo Tosatti
2024-02-27  8:36 ` Paolo Abeni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ba7c2cb75bb8141eb518c764ad8975054f0463.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=edumazet@google.com \
    --cc=frederic@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=vschneid@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®