From: "Martin Liška" <mliska@suse.cz>
To: lkml <linux-kernel@vger.kernel.org>
Cc: linux-perf-users@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: [PATCH] perf: print warning when HAVE_DEBUGINFOD_SUPPORT is not set
Date: Wed, 20 Apr 2022 15:32:55 +0200 [thread overview]
Message-ID: <35bae747-3951-dc3d-a66b-abf4cebcd9cb@suse.cz> (raw)
When one requests debuginfod, either via --debuginfod option, or
with a perf-config value, complain when perf is not built with it.
Signed-off-by: Martin Liska <mliska@suse.cz>
---
tools/perf/util/util.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index fb4f6616b5fa..289d83baaa2f 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -430,4 +430,9 @@ void perf_debuginfod_setup(struct perf_debuginfod *di)
setenv("DEBUGINFOD_URLS", di->urls, 1);
pr_debug("DEBUGINFOD_URLS=%s\n", getenv("DEBUGINFOD_URLS"));
+
+#ifndef HAVE_DEBUGINFOD_SUPPORT
+ if (di->set)
+ pr_warning("WARNING: debuginfod support requested, but perf is not built with it\n");
+#endif
}
--
2.35.3
next reply other threads:[~2022-04-20 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 13:32 Martin Liška [this message]
2022-04-20 16:34 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35bae747-3951-dc3d-a66b-abf4cebcd9cb@suse.cz \
--to=mliska@suse.cz \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®