From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A5CB3D6CD8 for ; Wed, 14 Oct 2026 16:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791994219; cv=none; b=QYpmbhndwgXRSaom6X+QJtDCmzRAaOQ9yY8hZ2xUMfNEoCTIo4BY01jrQ7dyDnaV9AidtrOuJ/x1x/LStVkDe8yFnvplTeTq6f+opz6Kv4AHxUT2dZWc05HhVkwi9ByR73E18cHH//GqkFhgrjwAxF8fBWwRHvyUfSgBj1x+tjs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791994219; c=relaxed/simple; bh=d9AZ1icpKYyYzs2G88pYV++7oRZ7y7xW+WF6rTZ94hQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XvawUixjulEqF1o5LeIGToRHVmfYohADl30BfgIDqL9zhMLFXN5ABekAeyMHX/jXRQr8YSQwjdsiZ/rO+dmG7eGKwmC1n0H2cu/dXgG1ruWjqFXFwr+FD5SJ/HoH4PeSkHxnZlAKfO54MmY1Fq7/Tn0i4GugtnLeLiBRzINoGJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o1qBldYU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aJ0/26cv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o1qBldYU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aJ0/26cv" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69EEbNN0152725 for ; Wed, 14 Oct 2026 16:10:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qj/1rZNvt2LirJIMlx3gBCi7fV2daYoXIXFAvUvD/kw=; b=o1qBldYUgfBT0Wyj lXIe2uKqgeyhqOtQPoGW6iuVtRynAPqqzMzlW2wXqn1A0W7AxuOgGZPv8mk7OwfE 7aNrA0jCQ/E+nM8M/4UbJwO+nkdq61lXxvMRUYKZhz9Trv5vmfmXNMRHoVCJ3PMa aw7zV8neGhm4Tiu4ke7TgQLi9dx6LYcvz0U+8GScZEhDInP8fPRh4BxjX8hgI9To sk2IiOleoupJzsDZBjNz7IGnZe3KM+oj9MPWpTljbxFTU4W4TM8eCJNyA612FqFe M5m/4OWHOQMNIyr2Wj1k8sHwSBsF2PA0kTt5SMGm4jjnZ76pT8VOaq+hFHXSLt+/ lvokBA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ha7aehhp7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Oct 2026 16:10:16 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3a8af172664so538936a91.0 for ; Wed, 14 Oct 2026 09:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791994215; x=1792599015; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qj/1rZNvt2LirJIMlx3gBCi7fV2daYoXIXFAvUvD/kw=; b=aJ0/26cv01m92AxYvpERc4rKjvkVyJrb2IMsxvYc77UxPw8+2uXv8hPjj1z8dq+ul1 qt3SWamSOKrOkjJsViKRAmuQsl4UwdNCjEmE6Ech2UM1s6hyZu8r6V43wQAu+WveFShK 7UpXcWdQktfDi7IqjOShNKU2dJjgYWUlZmqVNsYkvGlOD2g2StzxgPjrofkbC1qFXztb DMWF1reBWi+dB+qS4K0l/RrCU0CEvvZpc4ZRF89NfueDQF1LlHwX0O6jbq/7pUzehvuV t80A1sZD19CRFQVMwlwiqDFY+ePRNqq1oLAsIp4ouJj0hWdv2dtET0qPQDF0iOz+CqQG eGhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791994215; x=1792599015; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qj/1rZNvt2LirJIMlx3gBCi7fV2daYoXIXFAvUvD/kw=; b=l6w0BaZisYq6e/NV1pKI0mEHlMvaFxrbhXGhniq/phQitxl1XyzWOAoCQn2CNwa1R5 pkwt2OmAcvWTSqQsXLPol9Hl0MGLbsNnRli94JCvZnE0MFH1Ou5/ZpaC4M7Z+6GryeoE XS8gVWBQSsjwoGwwei1MaGRmibECoyeAZREEiLBeBTinzeE4ZUaawOtAUelTQ0TQM3bW D/yflwCyGfxseHTH3x50y7HPOdRyM2skoZPAO7PzKCY4gi+YZvfEajs3grwKKMxaMeaO WB3e78Dv7ROuqFlXRkp4xXQDQ8+gDKbjsGiCdVKyP9hfsx+a5AUzH70Q70lkirqCB0cX i5zQ== X-Forwarded-Encrypted: i=1; AKwUvBxwXjIZihohH3eLz5McDWN2gP7d1sSNWvry/ageti789A+cQZN8/3vOO4YGjryepM3ebNru9iZse6cK0Ng=@vger.kernel.org X-Gm-Message-State: AFq9FYJMHDUZ07KahD4JKi62xWJl4LVxKEemcbavHlylsSDZ1qnhifZR y7kfz2JCA/dvc7anGcE/PQomwepYhsrK6RDDrBM31MFSNfAjC5FokWYJkWtYUcbW6jQXPKLxO4M olIYgAzNodpy3NfyhONWaDGHocR6m/XQyBiRpuofEK4BpMdwDOcVsgqsUonXTFDgoeyA= X-Gm-Gg: AYBFou07lFvfNj5QxEJOWKKb8MtfOe7nCx04nuwJ19qonIa3lIvNa4aQahFsFnbODtA NznBYDtPdlEY1xxeVQgva/WjoJH+8u4XLnHVLTuAjWF6GrtOpSLTqNaCurTZjJvq9FMgLtfV/1e Txyg7fy1E+/VnZUwBJm1O+EXalKehj9V9y80mbi2qDoN6IgGdqu6LnmtiLSMpAztJD8LQ1goMFF bxFc7wrgD+wlnq3F4tJ7RSRm+ySEP2p0Rrlll5heezGCnKZj/UqCdCY3J/EFzsxUQUyzoqlBI3P +h5SNaUgWPI8fITTWIwxOULqaysrQ+433gxV3b8B21ipt53OQ6PIN7BeENFqgwnqHpu5FOCfouL FDKkmvmth7ZvHOrb8mRuCxY91g/lLvqfqabjDKFQ1YCo= X-Received: by 2002:a17:90a:bc8:b0:3a8:545a:9e87 with SMTP id 98e67ed59e1d1-3ab3a747e4dmr8849401a91.15.1791994215106; Wed, 14 Oct 2026 09:10:15 -0700 (PDT) X-Received: by 2002:a17:90a:bc8:b0:3a8:545a:9e87 with SMTP id 98e67ed59e1d1-3ab3a747e4dmr8849367a91.15.1791994213975; Wed, 14 Oct 2026 09:10:13 -0700 (PDT) Received: from [192.168.1.8] ([122.164.80.129]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd635c9792esm49825a12.22.2026.10.14.09.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 09:10:13 -0700 (PDT) Message-ID: <35bebc3a-8172-4c55-94a5-18c4047f7090@oss.qualcomm.com> Date: Wed, 14 Oct 2026 21:40:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI To: Varadarajan Narayanan , Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261012-08-dts-v7-0-77bd3d68d850@oss.qualcomm.com> <20261012-08-dts-v7-6-77bd3d68d850@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: O20uiDz5CKVTcGmTbjjV3A6rAX0ecszW X-Proofpoint-GUID: O20uiDz5CKVTcGmTbjjV3A6rAX0ecszW X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE0MDA2NCBTYWx0ZWRfX8nHwI/h3Akfo eoc+Q5vwIiqHLUXHnuhORTsQdtOCsCNOIj09rHczMSoEZ5wECgdwwBmDOzi/fLGPHjRJXaWDQZt Gja6T1yFmok48MyZB+GQFaT3rqR2Sto= X-Authority-Analysis: v=2.4 cv=NctzRGD4 c=1 sm=1 tr=0 ts=6acfa968 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=vSQal4Cqo5fxyC+YxRTyzw==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IlWm7PwFmQ6qje7k7KsA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE0MDA2NCBTYWx0ZWRfX74oB+4ITXpmu skMQmnJmpb0a0v9BTCaFJRHFFhipDvX+8FeV3LCl4O0IelX8f10SFKQxb/0Sd5ly7vrTcB3thnM MrrfEy2w+UgxaqQMCk9BbSYAPyYdzCZ5bZz3LOiKLAeyhNEth0zb+ObeXhnvOrZ7492YlZNJvPR jt7lFjLQDFgEy1Rf6Pmby9dzQigjp3wUc3YeIv14rh3YFb9VBgDqlZ9cTqKt+KWHXECMIOEPp1O N/HpMH6rxSF+gxbAXOUhkcAlUDFCt2N4V6CLFQ+LGuw1+LWzGOKbK89oWMVsB/CHAUmhUtN28a5 BQj2kgRtOr+LPfn3ABoec28E1U3GZYU7DlsH6s7VBDWZB4oWF8P+eE2apWwI5BYPgd5l5Tb9FXX 8R1b1fAO3gpVR/u7BUaSLB5rir8BfbSkLsmdL1ynTjuSB8/1jFZIK18Dbatp3XTUrhki7bsWNns B7Ez0+WcMtGuG7+k9YQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-13_01,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 impostorscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610140064 On 10/14/2026 10:33 AM, Varadarajan Narayanan wrote: > On Tue, Oct 13, 2026 at 04:43:36PM +0200, Konrad Dybcio wrote: >> On 10/12/26 9:23 AM, Varadarajan Narayanan wrote: >>> Describe the SDHCI ICE register region and clock, and enable CQE support >>> for the IPQ5210 SDHCI controller. >>> >>> Signed-off-by: Varadarajan Narayanan >>> --- >>> arch/arm64/boot/dts/qcom/ipq5210.dtsi | 15 +++++++++++---- >>> 1 file changed, 11 insertions(+), 4 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi >>> index d28d68a10958..c14b42c22616 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi >>> @@ -416,9 +416,11 @@ uart1: serial@1a84000 { >>> sdhc: mmc@7804000 { >>> compatible = "qcom,ipq5210-sdhci", "qcom,sdhci-msm-v5"; >>> reg = <0x0 0x07804000 0x0 0x1000>, >>> - <0x0 0x07805000 0x0 0x1000>; >>> + <0x0 0x07805000 0x0 0x1000>, >>> + <0x0 0x07808000 0x0 0x2000>; >>> reg-names = "hc", >>> - "cqhci"; >>> + "cqhci", >>> + "ice"; >> This should be a separate node, like on other SoCs to allow things >> like frequency scaling > Not sure I understand the comment correctly. I checked agatti, sdm630, > sdm670, sm6350, talos DT files and they have added the ICE region similar > to this. > > Can you please suggest an example, will follow that. Kodiak [1], Monaco [2] has a separate ICE node. For the frequency scaling / OPP support, series is still under review [3]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/kodiak.dtsi#n1085 [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/monaco.dtsi#n4883 [3] https://lore.kernel.org/linux-arm-msm/as9ksJKk55wYuoOS@hu-arakshit-hyd.qualcomm.com/T/#mf3a36cd811e7933bfa184366aa77b3f335c5a3ad Konrad, I hope you are referring the same. > > Thanks > Varada >