From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5029734A3B1 for ; Wed, 8 Apr 2026 13:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775654652; cv=none; b=HGAWYFI0B7u9e0c2LiEoB/yi/c+Ux5oFoPHUnO+2UTrHYPXEp3WimJEJIl6QoLU2YkASZUIQywwFfCkLAub1Gj+5Jh3v0hav6vMqmyzRjkYeiINqnzHqHRG3KjyIkIt0yPIavPkksP4fkEKSVjLF3qRpKMBdMQzON+JMi0DFLLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775654652; c=relaxed/simple; bh=AfFYQQUGwk44jOZbLBAWUljtUuIjTQ+BWSEwzzWUV1M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tcagHiXTpKxrCsNOHLGiOPlI7M/EOtyg3RQrf957tB6NWWsRAQhigPmRYr8WoGb22af7iCkjsvJJg4Aj0xTWRK7qMvRR5SBhmM9XTJOgIohr2r/UX4PKy2LGKfzRoSOLcP2l3ZtTOFbtY3hqf1/0KC29rPyQP16ZMqYt0XeIZLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hV3H/GLp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kLvhj5J8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hV3H/GLp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kLvhj5J8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 638CpBxc1619693 for ; Wed, 8 Apr 2026 13:24:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oGr79M7gQsrIfszEgdj7iKZUWTCSVw48bv+SAF4EKvM=; b=hV3H/GLpUcz5n7Ws VA+nLZoULyzv02XkfGa4XoDvamnIyZ/ecUC/rY9SHPYtaUhdmvE1L/LSflZ7ASwP oTEfRu3zSQPXlmpSYRVKwMfm/ipMS8puX3ECb5qu8u5pf+KOWvVXfVpUjIEhQz9/ hur+Jtb3diustn5N5JOyeeUUnm1krb7KweXx8ZjxDemDEnnzgo2WhNrCroYIm7ct Kswuv1oYSVqP3SjLK5opUaB0je1JB5z/V0Y8IVDWJsp2VIr49+QMtpdjnkOLcOan ZuYaMabh7zs78R8lXMHahDivWwuBZEw28fKEIffNkfEevQz+Zbk3YzJ3dGonXKUh XqmL8g== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddacrjy1v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 13:24:08 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-56d8ab2f3c7so361783e0c.0 for ; Wed, 08 Apr 2026 06:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775654648; x=1776259448; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oGr79M7gQsrIfszEgdj7iKZUWTCSVw48bv+SAF4EKvM=; b=kLvhj5J8CMCx+nyEH1EKpmi9NW9ciW+6MQs6sduh4QpLjHx8rhWwFn5Q9eSZhJsT6B qmyChKPtQePaEDuo+LMDm0Kch1hnC/stm6jJvluMFzZE2Z8+R+5pJ4KqpDDUWk6Elo/C 98/5yIADwXDssf3Biv8LY/dZNUPI9p3bq38eE53GzbvTN2W+qlJWp9KOlFkZZ/Ou1U22 QZ6ovy8OU65YLJFOg8w/Fh+j56WtPvvh97axfH3T7np4wO/3YmX6UdRI5KF8JOdbyaZx 1322CC4LvwtkJjjY2zH/xvViv/dNaJCxAMjxmFr7BPyPrjeSMbxaRIgZezAqX6mZWvCF XQCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775654648; x=1776259448; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oGr79M7gQsrIfszEgdj7iKZUWTCSVw48bv+SAF4EKvM=; b=TFwzTsOuTAkWj1AxmKiVOqW2gS9McStaOqE6H6M7r48/eFdbItX1CyWXeXo33FjJVB +FiBPrwB9ecpJhm5HtA0T8gjl06T5+mhpTs1eA6aR0TYTE6Qm7lep3Rq9RC9Q63NmzDt pHWQwM7XaqUq2uV1PNh02hz3MhBYrrlMnNVHUdtIY04sJAGeIBwY+TyjULytOsCZh49n sshbZnM+MlrgxVVsxF44XjYT+iz2NcjGs8Bhvlv38QYtpSJFB55MFBGQqf3S0+vee8Ru BdSa0J1T1zTHsFdsX0WEzPy1lIds8z4BMO6akbkVJC8fZsky4QH8eNLjEyO7b69iGVTJ uLcg== X-Forwarded-Encrypted: i=1; AJvYcCWWGBY79guxdq4ZNFD1EYIfcJUC+5aPA9yoxNxuhm4EeWq94KGczvNkyqBGeFcb85QnDILbsR8YLZQ28uc=@vger.kernel.org X-Gm-Message-State: AOJu0YxRnejBkt912zqY89x7vzGcLeolMQ95hTV5gXEVtQ2Rq6Idz7Kp au3Wdxxy+0zUgct3g1pYAL5tbvFLVBoxzI08gndVLqoI7dj7kwXnMnkcoJzVkoKOfOSrOGhNZ9y 56WMGak2lcite8GWyRor9AEritc63bPdyk2fJp67zi0CWImLK1iMsTWSuRS94fqN5nBaei5yn3u 0= X-Gm-Gg: AeBDiesPDQJxbUrUmIJOavMrHDXQSZubf2hgl9RrwZxOVfxBBU6+xxQFKBxhEd3YVm5 Sdrw/xP2vXyeqRvK1fiSR5PapKiJJ9QWrtC/xuIzg7o6i2ld3Acy3BFk8rTv5pcCVVxTLmGF+Bh 2yOh5XeH2siMOvM7ycbh2t1nJKckIGG+vn3nZrrDTHzUhUN0BnDi76L00TFyWS+Aq4HT+wNPmsU FDcZ/FYgJ2Ql8Ur4vSp3uJSrc6lizgs894f8hZXc/YFEtS67x6374wrjbmlb1joAHK/HWOaQh6w f99rO+pYPz8EXvWE4jPmXEl4F3E8ZHPTY6JlG7hhUM+By4dqad45TyQeXsAmzM8Yi6X1Tdfg7bQ 0IFZthIhNV6C8WEHwUo8XvI99m6cI3VAt3ne2RsXSUxUXxOYghzphUTx6WEaWCakM65V9q+FMSk lb/Tk= X-Received: by 2002:a05:6122:6584:b0:567:4293:8d38 with SMTP id 71dfb90a1353d-56f185095aemr784093e0c.0.1775654647909; Wed, 08 Apr 2026 06:24:07 -0700 (PDT) X-Received: by 2002:a05:6122:6584:b0:567:4293:8d38 with SMTP id 71dfb90a1353d-56f185095aemr784065e0c.0.1775654647372; Wed, 08 Apr 2026 06:24:07 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cff131csm650248866b.52.2026.04.08.06.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 06:24:06 -0700 (PDT) Message-ID: <35c2fb30-659e-4a2a-ab06-498dbd288cd9@oss.qualcomm.com> Date: Wed, 8 Apr 2026 15:24:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] phy: qcom: m31-eusb2: Make USB repeater optional To: Abel Vesa , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Wesley Cheng , Dmitry Baryshkov , Bjorn Andersson References: <20260302-phy-qcom-m31-eusb2-make-repeater-optional-v2-1-dbf714c72056@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260302-phy-qcom-m31-eusb2-make-repeater-optional-v2-1-dbf714c72056@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 8zMQyvUzcQuOSEV6nsJDQRnh7NqB3zoa X-Proofpoint-GUID: 8zMQyvUzcQuOSEV6nsJDQRnh7NqB3zoa X-Authority-Analysis: v=2.4 cv=WZs8rUhX c=1 sm=1 tr=0 ts=69d656f8 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bC-a23v3AAAA:8 a=TBTR2SLNknTDqd2QJGIA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDEyMyBTYWx0ZWRfX9ixLZvBvtV0R DhSykLejkMq/NZTaBSuiJvOjlG1vkwhRDZk6BmVusjQOh1RmgFSEiM1I4ov+eBU+mM8I/W9Fhov WYWVsECRhgNSNRVlToSvKAOcR1kblVlX8OHhj2G8/mtDze4Sj7XVOUb694wyE4Aq6kNdySrmmda ezfBe+24j/LuvvgIViOTkkBBR8ULXEoUMev9XHEjEvdl58WD1HiE3Yy2eZm6kgRJ/k1Yqhsi1Ic IGtOavhjibwuqTcHMJlpPf6M7OyhQRs4uGqF8qCcojJ3rjuiwOUGZHS+Inzbw9ATcNzbMMCJIB9 PnIknws4hhxr/UA3oiz5Ac+chj0lJJDn1Ns8TedGkKOqLwBiuQjIzz0+K8k+toHwo1YgwjFagtb dTs1VgajuQa8WH/argEo86GwOs6kx3jOM4Flr6zNS6jvbN43PTXRRUbIJaLs9y8E/J/l+2nG1ux nm7EMOVtG2ccRWG0L6Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_04,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080123 On 3/2/26 9:34 AM, Abel Vesa wrote: > From: Wesley Cheng > > A repeater is not required for the PHY to function. On systems with > multiple PHY instances connected to a multi-port controller, some PHYs > may be unconnected. All PHYs must still probe successfully even without > attached repeaters, otherwise the controller probe fails. > > So make it optional. > > Signed-off-by: Wesley Cheng > [abel.vesa@oss.qualcomm.com: commit re-worded to reflect actual reason] > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Bjorn Andersson > Signed-off-by: Abel Vesa > --- This is a trivial patch that fixes probe errors in some hw configurations.. Can we sneak it in for -fixes, or is it too late, Vinod? Konrad > This has been sent initially by Wesley here: > https://lore.kernel.org/all/20250920032108.242643-10-wesley.cheng@oss.qualcomm.com/ > > This is still needed, but for a different reason, so re-worded the > commit message to reflect why. > --- > Changes in v2: > - Picked up Bjorn's and Dmitry's R-b tags. > - Fixed the subject line, as Bjorn suggested. > - Link to v1: https://patch.msgid.link/20260227-phy-qcom-m31-eusb2-make-repeater-optional-v1-1-07a086bbaba4@oss.qualcomm.com > --- > drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c > index 95cd3175926d..70a81ab2482f 100644 > --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c > +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c > @@ -285,7 +285,7 @@ static int m31eusb2_phy_probe(struct platform_device *pdev) > > phy_set_drvdata(phy->phy, phy); > > - phy->repeater = devm_of_phy_get_by_index(dev, dev->of_node, 0); > + phy->repeater = devm_phy_optional_get(dev, NULL); > if (IS_ERR(phy->repeater)) > return dev_err_probe(dev, PTR_ERR(phy->repeater), > "failed to get repeater\n"); > > --- > base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31 > change-id: 20260227-phy-qcom-m31-eusb2-make-repeater-optional-621c8c1c0354 > > Best regards, > -- > Abel Vesa > >