From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1543EECAAD8 for ; Fri, 23 Sep 2022 09:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbiIWJN4 (ORCPT ); Fri, 23 Sep 2022 05:13:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbiIWJNu (ORCPT ); Fri, 23 Sep 2022 05:13:50 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CAC912E429 for ; Fri, 23 Sep 2022 02:13:50 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 19A456602038; Fri, 23 Sep 2022 10:13:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663924428; bh=O5Eq5O5jGm/xMQpjO7QiI8PnAOOsQRcDFnut+zQiQ6M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=d/9uP7oVrChf5rlUDoIxTSXljBHeD2JE/1wRzcd8Ul85tsdGpXtTm75XTbEAwAhzW przhgoZciIC9i6V+gBbzNVylcu6FdnFHaNC8ZbyUTS6GlI+V8AA9O6NWp/Ho3Jszib MXAXD9e6URBLlAKkXVEBv5VigNuQLSPqPrQEcwNyeUDumCCWqLeSYZcgYoENI0PTT8 +Cmodwit3vHGcAnOZfLwtLYdlqoP/194Nz8xSWIBagMRLJh738mWFJ6YaW3RCjZ7Ko vhOIPfAGrVT3egXH9LwFcA+Lxcpzy0Tq9VD7sr0UgD+hxZXkjGJGf09mXg6eDzHLqF KsPLxkZYjdQ+Q== Message-ID: <35c3bf57-4659-2356-5008-d1422c2d609d@collabora.com> Date: Fri, 23 Sep 2022 11:13:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v8,1/3] soc: mediatek: Add all settings to mtk_mmsys_ddp_dpi_fmt_config func Content-Language: en-US To: xinlei.lee@mediatek.com, matthias.bgg@gmail.com, jason-jh.lin@mediatek.com, rex-bc.chen@mediatek.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jitao.shi@mediatek.com References: <1663850702-26529-1-git-send-email-xinlei.lee@mediatek.com> <1663850702-26529-2-git-send-email-xinlei.lee@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <1663850702-26529-2-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 22/09/22 14:45, xinlei.lee@mediatek.com ha scritto: > From: Xinlei Lee > > The difference between MT8186 and other ICs is that when modifying the > output format, we need to modify the mmsys_base+0x400 register to take > effect. > So when setting the dpi output format, we need to call mmsys_func to set > it to MT8186 synchronously. > Adding mmsys all the settings that need to be modified with dpi are for mt8186. > > Fixes: a071e52f75d1 ("soc: mediatek: Add mmsys func to adapt to dpi output for MT8186") > > Signed-off-by: Xinlei Lee Reviewed-by: AngeloGioacchino Del Regno