From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, linux-pm@vger.kernel.org
Cc: Navid Emamdoost <emamd001@umn.edu>,
linux-kernel@vger.kernel.org, Kangjie Lu <kjlu@umn.edu>,
Qiushi Wu <wu000273@umn.edu>,
Stephen McCamant <mccamant@cs.umn.edu>,
Sebastian Reichel <sre@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dinghao Liu <dinghao.liu@zju.edu.cn>
Subject: Re: [PATCH] power: supply: bq24190_charger.c: call pm_runtime_put in pm_runtime_get_sync failed case
Date: Mon, 1 Jun 2020 10:01:20 +0200 [thread overview]
Message-ID: <35c8ecf5-c3d0-33a5-3bb5-f8dbbe88647c@web.de> (raw)
> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value call pm_runtime_put_autosuspend.
* I find the word “usage_count” questionable in this change description.
* Will the tag “Fixes” become relevant for the commit message?
* Can an other label be more helpful than “out”?
* Would you like to take another look at a related update suggestion
like “power: supply: bq24190_charger: Fix runtime PM imbalance on error”?
https://lore.kernel.org/linux-pm/20200525110540.6949-1-dinghao.liu@zju.edu.cn/
https://lore.kernel.org/patchwork/patch/1246783/
Regards,
Markus
next reply other threads:[~2020-06-01 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 8:01 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-01 7:03 Navid Emamdoost
2020-06-01 6:25 Navid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c8ecf5-c3d0-33a5-3bb5-f8dbbe88647c@web.de \
--to=markus.elfring@web.de \
--cc=dinghao.liu@zju.edu.cn \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mccamant@cs.umn.edu \
--cc=navid.emamdoost@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sre@kernel.org \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®