mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de, macro@linux-mips.org
Cc: linux-kernel@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>
Subject: [PATCH 5/9] x86: apic - unify connect_bsp_APIC
Date: Sun, 17 Aug 2008 23:41:43 +0400	[thread overview]
Message-ID: <35ce95a46281c17089daf07f70c75598fd40d0d2.1219001352.git.gorcunov@gmail.com> (raw)
In-Reply-To: <1219002107-21832-1-git-send-email-gorcunov@gmail.com>
In-Reply-To: <68106c6e85398a15b2a5d556764159541e1d66fe.1219001352.git.gorcunov@gmail.com>

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 arch/x86/kernel/apic_32.c |    2 ++
 arch/x86/kernel/apic_64.c |   20 ++++++++++++++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic_32.c b/arch/x86/kernel/apic_32.c
index d4efe86..6d230e9 100644
--- a/arch/x86/kernel/apic_32.c
+++ b/arch/x86/kernel/apic_32.c
@@ -1387,6 +1387,7 @@ void smp_error_interrupt(struct pt_regs *regs)
  */
 void __init connect_bsp_APIC(void)
 {
+#ifdef CONFIG_X86_32
 	if (pic_mode) {
 		/*
 		 * Do not trust the local APIC being empty at bootup.
@@ -1401,6 +1402,7 @@ void __init connect_bsp_APIC(void)
 		outb(0x70, 0x22);
 		outb(0x01, 0x23);
 	}
+#endif
 	enable_apic_mode();
 }
 
diff --git a/arch/x86/kernel/apic_64.c b/arch/x86/kernel/apic_64.c
index cbca413..600ce2f 100644
--- a/arch/x86/kernel/apic_64.c
+++ b/arch/x86/kernel/apic_64.c
@@ -1285,10 +1285,26 @@ asmlinkage void smp_error_interrupt(void)
 }
 
 /**
- *  * connect_bsp_APIC - attach the APIC to the interrupt system
- *   */
+ * connect_bsp_APIC - attach the APIC to the interrupt system
+ */
 void __init connect_bsp_APIC(void)
 {
+#ifdef CONFIG_X86_32
+	if (pic_mode) {
+		/*
+		 * Do not trust the local APIC being empty at bootup.
+		 */
+		clear_local_APIC();
+		/*
+		 * PIC mode, enable APIC mode in the IMCR, i.e.  connect BSP's
+		 * local APIC to INT and NMI lines.
+		 */
+		apic_printk(APIC_VERBOSE, "leaving PIC mode, "
+				"enabling APIC mode.\n");
+		outb(0x70, 0x22);
+		outb(0x01, 0x23);
+	}
+#endif
 	enable_apic_mode();
 }
 
-- 
1.6.0.rc1.34.g0fe8c


  parent reply	other threads:[~2008-08-17 19:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 19:41 [PATCH 0/9] -tip/apic merging one more series Cyrill Gorcunov
2008-08-17 19:41 ` [PATCH 1/9] x86: apic - rearrange maxcpu definition Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 2/9] x86: apic - unify setup_boot_APIC_clock Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 3/9] x86: apic - unify disable_local_APIC Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 4/9] " Cyrill Gorcunov
2008-08-17 19:41   ` Cyrill Gorcunov [this message]
2008-08-17 19:41   ` [PATCH 6/9] x86: apic - unify lapic_setup_esr Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 7/9] x86: apic - unify __setup_APIC_LVTT Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 8/9] x86: apic - unify disconnect_bsp_APIC Cyrill Gorcunov
2008-08-17 19:41   ` [PATCH 9/9] x86: apic - generic_processor_info Cyrill Gorcunov
2008-08-17 21:53 ` [PATCH 0/9] -tip/apic merging one more series Yinghai Lu
2008-08-18  4:22   ` Cyrill Gorcunov
2008-08-18  7:18     ` Ingo Molnar
2008-08-18  7:24       ` Ingo Molnar
2008-08-18  7:41         ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35ce95a46281c17089daf07f70c75598fd40d0d2.1219001352.git.gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®