From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941435AbcIZDe2 (ORCPT ); Sun, 25 Sep 2016 23:34:28 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:33299 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbcIZDe1 (ORCPT ); Sun, 25 Sep 2016 23:34:27 -0400 Subject: [PATCH v2] Staging: android: fixed permissions style issue To: Joe Perches , greg@kroah.com References: <1474858836.2238.10.camel@perches.com> Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Eric Salem Message-ID: <35cf54aa-2ab4-b58d-194c-5c278f1f0a46@gmail.com> Date: Sun, 25 Sep 2016 22:33:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1474858836.2238.10.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed a coding style issue. Changed symbolic permissions to octal. Signed-off-by: Eric Salem --- drivers/staging/android/lowmemorykiller.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 80d7adf..ec3b665 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -204,10 +204,9 @@ device_initcall(lowmem_init); * not really modular, but the easiest way to keep compat with existing * bootargs behaviour is to continue using module_param here. */ -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); -module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, - S_IRUGO | S_IWUSR); +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); +module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, - S_IRUGO | S_IWUSR); -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); + 0644); +module_param_named(debug_level, lowmem_debug_level, uint, 0644); -- 2.7.4 On 09/25/2016 10:00 PM, Joe Perches wrote: > On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote: >> Fixed a coding style issue. Changed symbolic permissions to octal. > > If you do these, please shorten the lines where possible. > >> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > [] >> @@ -204,10 +204,10 @@ device_initcall(lowmem_init); >> * not really modular, but the easiest way to keep compat with existing >> * bootargs behaviour is to continue using module_param here. >> */ >> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); >> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); >> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, >> - S_IRUGO | S_IWUSR); >> + 0644); > > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); > > etc... >