From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 104FA21423C for ; Sun, 9 Nov 2025 07:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762675048; cv=none; b=lhzBTxuam15mOrqtUMMF2b60o4opwwbBHWEfRAglACkGtMPxnH6J0N0Wy8h6fnF0QQZmPcwT3ZDwxXBglqys3lACm+bVupaJQHPw0xuPwPNj1bauCuke4BFB3gOKTm/Eh5dbQW2JbuCfrH8e5Nm/gtdNI59d8XhtRqQoPvcXUfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762675048; c=relaxed/simple; bh=aMVY8ydjIK+gBsyjP/Qdj9zuQ38V6U+yFDnq3j8ElaI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s2MwypaPnKKgr6lmprMeSw4eEN4AnBiGb26m+lCJirPwkWMC8XLNhvTEoZIPCS0L+k4fPituuC5uEMeAawh15KCvYit7b7DSsetcC8eCQKJ/uFh2gGXoVEKz5jq5Y15Yx2d1JR+Ayr5rmH2VSftuCubo37PrYfKm13Yf0GDdoEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fvvWyaFm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HO8dLVd9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fvvWyaFm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HO8dLVd9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762675046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ggXgIZ4Av8adM96XYVeUSve/XM/3H02+HEMRjGXlR6Q=; b=fvvWyaFmBGdVEyJqGqASTEoLN6ClBMYLASyQrArnSkMesYCJKq4b+66oqqkcztlb3+QQmo QpmAAbJbIbUMHKKhMm1sbByTnIop4vMreSWrS+CmgODxi4JX6ewaN6JoTTVD+nWmyOMzVv UnFKGX45pW6VHySjZfMQXKSXFWFbVi0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-cOtJFzw4MwGhjRFsbrT8cQ-1; Sun, 09 Nov 2025 02:57:24 -0500 X-MC-Unique: cOtJFzw4MwGhjRFsbrT8cQ-1 X-Mimecast-MFC-AGG-ID: cOtJFzw4MwGhjRFsbrT8cQ_1762675043 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b72ad85ee9aso263994866b.3 for ; Sat, 08 Nov 2025 23:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762675043; x=1763279843; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ggXgIZ4Av8adM96XYVeUSve/XM/3H02+HEMRjGXlR6Q=; b=HO8dLVd9haqhjt74i0I2pcpLjd5r3nvssE/a1eO9x5oL+7YKTy/fbh54pu9iJzA+aZ O4hR1TMzy2owVN0E6CFL7QpnQJvhmveA6BkCd+PfjXhy9cWevpJfjsmdiUxJUUIj/eMv rjOBS2PukrdJpvj+APS3T4a+Sz/EeIF1QgExvirJvklqmT9gnwesFyo226wEL0qVo6QO LdJKvX5F70mGjVkCiX7EAG6c8iOTP2zB2erzS9SJcyQjhg0z4xy02gD6+HlNpR/W1/Kz 4sGb5Jv2sCV7qZPNU9qdpPLpVe7ASVTjDq5Po8W6SCahdjQUAyX52jv9x3D5P+89a86G 6MHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762675043; x=1763279843; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ggXgIZ4Av8adM96XYVeUSve/XM/3H02+HEMRjGXlR6Q=; b=gAbLbJofXAp6Q4LP1KgAiMHhIVbJ0m25CIgJ4gstYbBPWWFiR1hLqa8ewv5jln9QvM eUrwpHKvZHnAjiByN/i7LCRDYp/AsEdS1dx+3UT0BEIVY+dP4wFUNQCUldJoozvXvIbY 2FwReN69VaPZVe5j2Hn/qSg9wJj1rxyGTEAB8+ydzQX+aLnCyQ/Bhk77vLMhmISozYqp rUQq+57N55O8CtIxsaAmUA1e5Bg+FOxnKA6OfIfqlNoJoN0BAbXGsPw6QkXHh1JumVXG IEoHbpsTfosr2CqINHpQB/DnfCe50gEhfr8xqUvsWIYzH2rYYuC+yjULqHyCbSpa92QP nUwQ== X-Forwarded-Encrypted: i=1; AJvYcCVCEcNS/rZC9cKe6BifIQa56OMFszwIjjwtzihgy8XLgHCUmch6o57T7B5ii9oDS8nTy4TE5x0oDj9D+94=@vger.kernel.org X-Gm-Message-State: AOJu0YwcgvQoyEQ8bt0venZe3aNMhY+Zefuw4vtYeO16vixHNsONcWuW iE15MQ7QpkNZB4SAN7YWS5ri+6CalDTOxxOJmImLY7esOxWul1bMFrzejhVyV7JX5BPnnm3G+79 5hVulYfldCknOKPp5g0gUt0OQrbaEHuCnoRg+mTWnGtBoZ9NjO+H9t8HGpZk9oytR7w== X-Gm-Gg: ASbGnctlEVXDZJFGVgl1NyDAGLsNS1xQ3dXvKQLy8K6/idpZ1dnjPDIiZDlav+g4O20 8kgrT269CEaKNA6ybiGGyF1oi0F0qap6z6lKw+S0TcsEzwALFkgwJ4LQ4H6B+5ammuBtDARDYa+ S7jC3docgqZDLGWszzLnxIVdFGef0JNJHkmuGfmRIUB/gbH4NXN95bAjpUC9J2G3k1ql6slQ/c8 5F4nmc/Ljf1g9IxgHosEKcTygqF4x9vYhYjwz48ZnUiymFY+pYes4j3I431uOWsFLDeVX9yh55y XvveVIsk85OH3TYCV2d3/gRVfrHv01syc1o3vkfXd/Si17tT24/XcmbDka7UvnprhBcxF2MZGlg EOBt6hfXWl2moEFDy16iOZlDQupbPDCx+TpWuqYuLdlkqaX6/KFRjXeI7dgHjK6LwkeF6yD1oPe 6u4nAw X-Received: by 2002:a17:907:60c8:b0:b4c:137d:89bb with SMTP id a640c23a62f3a-b72e037ab1amr450223966b.29.1762675043259; Sat, 08 Nov 2025 23:57:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEY/mAo+2HtrMHSZJM1dBAA4+rvfrevI858WJSml1/nFkNtAp06GLC7ns/SqzWwTfuAzgf5VQ== X-Received: by 2002:a17:907:60c8:b0:b4c:137d:89bb with SMTP id a640c23a62f3a-b72e037ab1amr450222766b.29.1762675042852; Sat, 08 Nov 2025 23:57:22 -0800 (PST) Received: from [192.168.10.48] ([151.95.110.222]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-b72fcde0779sm93426566b.40.2025.11.08.23.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Nov 2025 23:57:22 -0800 (PST) Message-ID: <35d28432-349c-4157-8c9e-7d4a9d8bd50f@redhat.com> Date: Sun, 9 Nov 2025 08:57:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] KVM: SVM: LBR virtualization fixes To: Yosry Ahmed , Sean Christopherson Cc: Jim Mattson , Maxim Levitsky , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251108004524.1600006-1-yosry.ahmed@linux.dev> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20251108004524.1600006-1-yosry.ahmed@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/8/25 01:45, Yosry Ahmed wrote: > This series fixes multiple problems with LBR virtualization, including a > fun problem that leads to L1 reading the host's LBR MSRs. It also > considerably simplifies the code. > > The series has a selftest in the end that verifies that save/restore > work correctly. I will send a couple of new kvm-unit-tests separately > that exercise the bugs fixed by patches 2 & 3. Thanks, I've applied patches 1-3 for now. Save/restore has been broken for 17 years so it can wait the next release anyway. :) Paolo > > Yosry Ahmed (6): > KVM: SVM: Mark VMCB_LBR dirty when MSR_IA32_DEBUGCTLMSR is updated > KVM: nSVM: Always recalculate LBR MSR intercepts in svm_update_lbrv() > KVM: nSVM: Fix and simplify LBR virtualization handling with nested > KVM: SVM: Switch svm_copy_lbrs() to a macro > KVM: SVM: Add missing save/restore handling of LBR MSRs > KVM: selftests: Add a test for LBR save/restore (ft. nested) > > arch/x86/kvm/svm/nested.c | 31 ++-- > arch/x86/kvm/svm/svm.c | 98 ++++++----- > arch/x86/kvm/svm/svm.h | 10 +- > arch/x86/kvm/x86.c | 3 + > tools/testing/selftests/kvm/Makefile.kvm | 1 + > .../selftests/kvm/include/x86/processor.h | 5 + > .../selftests/kvm/x86/svm_lbr_nested_state.c | 155 ++++++++++++++++++ > 7 files changed, 236 insertions(+), 67 deletions(-) > create mode 100644 tools/testing/selftests/kvm/x86/svm_lbr_nested_state.c >