From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B441320CA2 for ; Tue, 25 Nov 2025 13:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764076164; cv=none; b=DHpk3O36xLEKLMJQRUfUvosBX/cvfOClpv+3CSD53UcV/rnyhQb4kDe4onjtLXpb4A5QFT3V92UTeExesCllTr/6UWh1zGFmEa5Oi2fWy+IrRoSsW330hc0x7dPPGPMlxvM/86oGIQ48LozxUTDKflci+5dStO7AeycN9qNytmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764076164; c=relaxed/simple; bh=E+cx4YIlZDTE5ranL+JGZLoHRziPh06lGjk3sOE5rIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lJ+i75MJ0gbcKcb+BHIA4JJjTsrqSx9nXbend8fWHH9mXow60YEn47IU28T8MRtj+wHLfjsjoEZ+TwO5YGlevktpkQ6EETShvcuNUQdjT+igNZbzzcLOENRvRXW+bF5zT7giszWiRPR0qShGN66mvi9XLaZLjgKMFExpMTpn7cM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UhwrwdnX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jR0WUDwa; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UhwrwdnX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jR0WUDwa" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5APBKlek1672147 for ; Tue, 25 Nov 2025 13:09:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZYGxtqapSZXIZO2DUW75eRhcur6TpqVwVTgyc7wCOus=; b=UhwrwdnXpKZJ7Y6V bCvytmpFwxctRpBFfqV7Qz3f888WfGB5Pv1/GyhgMa80BHqnkVOY8YHg0WxEZkQV X0l5wOB1XmfCoV6RaKAO1RLLK3oTTZWnl8XpCqpWcWZ5XYKDa7ilxxsGa2FkTgsi zX+UzSJlwexEJbsMj4Y0ucSDoOSrdm+DgszXL8Ja38zT2qQrNPZlz0auW3TdcsxN amszbPzb/MBpPeOgFl4zjX92APHWizIFef3oWRUAm/jPUXd8UIzy8vtdnFnkBVPk XEduQCRQZRR+NZS6S0HH3K6bKPZhDebA2qJMuCm4Pel4MJHG6mZHJSrMrhtCuAob ScPkTA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4an5w81f66-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 13:09:20 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7a4c4eeeef2so13196710b3a.0 for ; Tue, 25 Nov 2025 05:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764076160; x=1764680960; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZYGxtqapSZXIZO2DUW75eRhcur6TpqVwVTgyc7wCOus=; b=jR0WUDwa/MX6fOCj7QoWCS58D+/h/iwGadvZ7UIZGLLeEjFK9Qz+hMC+cOnY9RDjyU BBW7I6+TUbVDkilv7RWBPq4M9akLzKUEtIw3aDqhwJ/uMMKvYZAwu5Z4DXGHcXKztgPH kj/82vu5ZaaxQ3apsQuG+YbRrT+ctv6M6OtRHsAx4ZjaJQQJ0Y3aYd91TQ6nYPKIA6yL qa4c4ufofy3f724nsAveksmuuYEsMQdFy++D2YxU6MGRnoWX5bOpiLxDqI+ef3pbKwX2 UBpVcVBXxLusyRx2nZLawe4BtHOsQ6LONPqw+Joq+OOsW0p6PQVkQ7HnxnJ7QszBcVfe Y0FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764076160; x=1764680960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZYGxtqapSZXIZO2DUW75eRhcur6TpqVwVTgyc7wCOus=; b=R7n2kV+4pUH5p2+8MdhVUG4244bPb0a++VXhigfEfgph+8dyHzSDCCoOKndTmI6XXT dLvdv3ZrFnStGUhJ1ZF9dD8xbDv4Qf+3euIV94pVuKIPZB+gTOThxjtYZheDv682G6EK 45tGykxx2wuu60tHDnjZM/DaVePRB3G+V9YbtyfCqbNhP66fIk+7dHlMv/Iyq6+x6+z1 v9UnH84wFZLtBZbBrnyK4rzp/+mobRrRhMfuzSw1OMSD/yjLpkZrH4oBAhVpD7ChlmZm QAsMtZeaQt4xDScuMiBtuDYKECiyFzXwOwH0/sfsxgEM7Ek9lsWYYXBN1LPUdvMqokgL Bv7g== X-Forwarded-Encrypted: i=1; AJvYcCU2yZ6iL/11bawmGgBLJkDYTxw/cM/xpZe68l4w/9Nsaif6+PCJfdocTHWKh2v1VvHNyD7WOT3RcJnMRJk=@vger.kernel.org X-Gm-Message-State: AOJu0YwexQjTo1396RktBFxIYhHLY3PzmXeTFzwoJCat+EDtK4OijSxb FRKv4dejEVeKrgSkMGtVMugkD5kjxaqHAS/p4CrNP9QPIAdME7VkVIhNaawLa0fueI8Fb5dN4Fg 4ywvka+HJa3P0i0U63gDuVPveLmjApYpeJM2vX5wtCYvZQg3jPG1IJ7+BCEq3+DQrOu8= X-Gm-Gg: ASbGncvUQ71iSDrUzi/08GpseicjOIAxljj4GCk6VGuJ+cAqhxFnlg5iaTRRvAxqcRx 4PBv+g98Sg5mZSNf9TNXsMYtsxpcz/XKoL9iCNuukoR7kV+4/Icfjs95xqN1nq5dGIXc/JEzBm4 4B8JbGDaVXs43yddp9pL+tZgSREUyboADXWcSpEwRF6QzpwRkMDCWgVFrT0eNQ+Xkg2b5DHI6wR iEtnzVrS1lZlpdTx3L0Zd4VyjQ1ABYkPuWq50n7Ve9WN2VdkDh0gRw1KHIgu7pCjugWOktPTRLi PRtdw1DzkhIP0d/UznI5mdLRebgURYaX2i02gcRONhDzTXmTc8sfkfgyRc9W4TN06lLSbzXJvqk DNagGgnhe1W1Zqs3FLTbMd8TdW+41X9s5q63s82qmHw== X-Received: by 2002:a05:6a00:181c:b0:7ad:c017:171e with SMTP id d2e1a72fcca58-7ca877f7d1fmr3282337b3a.2.1764076159694; Tue, 25 Nov 2025 05:09:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvd7ZftKwTZuop1VYd2YmbO9mLAwUD0VSNo05pm4Qka3y82OC6qyVCz4qTVUK3FYLPrVVtpQ== X-Received: by 2002:a05:6a00:181c:b0:7ad:c017:171e with SMTP id d2e1a72fcca58-7ca877f7d1fmr3282298b3a.2.1764076159157; Tue, 25 Nov 2025 05:09:19 -0800 (PST) Received: from [10.0.0.3] ([106.222.230.111]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f024b7d2sm17704749b3a.40.2025.11.25.05.09.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 05:09:18 -0800 (PST) Message-ID: <35d86818-8b50-1c0e-40a0-5f80c4b24a32@oss.qualcomm.com> Date: Tue, 25 Nov 2025 18:39:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] media: venus: assign unique bus_info strings for encoder and decoder Content-Language: en-US To: Jorge Ramirez , Dikshita Agarwal Cc: vikash.garodia@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251121184306.218169-1-jorge.ramirez@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDEwOCBTYWx0ZWRfX79ENP791DjNS HPw7V4fwR/nY33LlqL7hgI4KnySXpb7DlHpHvchNC7dNohnv8U/9EDh25QcC+KIGanN/rzv75DT eHSzjUbrOUyZDK28iW6bPusubOUK1Yn1/YN6WdUtEFxhajy2fG/BgtRXhcQEdFVrNzNzBEFQARn DUTxkNuXndipVJchXskmincJf6ChRjVvGeI0HLpqiWyaK26Hi2LyMcsvJ3lTE23Pzutb/2iXOFZ P4WFd7u6UoVgLobtFGmoqCpe5j0UDiYdEF3pvOGhxirOtLp/WNaBOMADXY/v9Nvy/jEBxAlI0fD H67eClkhIGcpTn8gszMXleyyp8/oRtcEdHBqMlSndvNciImR7MlmSqH4N9auBpTSiTUMwnrRVLT wVqDzJTJ0YCTqNZoUFsXBfTnR+tqkg== X-Authority-Analysis: v=2.4 cv=RvTI7SmK c=1 sm=1 tr=0 ts=6925aa80 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=12FOtvgV4D2gsqRYbU+y8g==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=xOd6jRPJAAAA:8 a=EUspDBNiAAAA:8 a=N3h5R79uZq5wuEpuAqEA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: -190dcqf9qcpcRG0Qo_sedkBD2Ybf-xe X-Proofpoint-GUID: -190dcqf9qcpcRG0Qo_sedkBD2Ybf-xe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250108 On 11/25/2025 6:22 PM, Jorge Ramirez wrote: > On 25/11/25 13:59:56, Dikshita Agarwal wrote: >> >> >> On 11/22/2025 12:13 AM, Jorge Ramirez-Ortiz wrote: >>> The Venus encoder and decoder video devices currently report the same >>> bus_info string ("platform:qcom-venus"). >>> >>> Assign unique bus_info identifiers by appending ":dec" and ":enc" to the >>> parent device name. With this change v4l2-ctl will display two separate >>> logical devices >>> >>> Signed-off-by: Jorge Ramirez-Ortiz >>> --- >>> drivers/media/platform/qcom/venus/vdec.c | 5 +++++ >>> drivers/media/platform/qcom/venus/venc.c | 5 +++++ >>> 2 files changed, 10 insertions(+) >>> >>> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c >>> index 4a6641fdffcf..63f6ae1ff6ac 100644 >>> --- a/drivers/media/platform/qcom/venus/vdec.c >>> +++ b/drivers/media/platform/qcom/venus/vdec.c >>> @@ -433,9 +433,14 @@ vdec_g_selection(struct file *file, void *fh, struct v4l2_selection *s) >>> static int >>> vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap) >>> { >>> + struct venus_inst *inst = to_inst(file); >>> + struct venus_core *core = inst->core; >>> + >>> strscpy(cap->driver, "qcom-venus", sizeof(cap->driver)); >>> strscpy(cap->card, "Qualcomm Venus video decoder", sizeof(cap->card)); >>> strscpy(cap->bus_info, "platform:qcom-venus", sizeof(cap->bus_info)); >>> + snprintf(cap->bus_info, sizeof(cap->bus_info), >>> + "platform:%s:dec", dev_name(core->dev)); >> >> Is there a reason to keep both strscpy() and snprintf() for cap->bus_info? >> The second call to snprintf() seems to overwrite the value set by >> strscpy(), making the first assignment redundant. Would it be cleaner to >> remove the strscpy() line and rely solely on snprintf()? > > argh, my bad, you are right. will fix. > > perhaps we should just have instead > > decoder: > strscpy(cap->bus_info,"platform:qcom-venus-dec", sizeof(cap->bus_info)); > > encoder: > strscpy(cap->bus_info, "platform:qcom-venus-enc",sizeof(cap->bus_info)); on the encoder > > I suppose the additional info provided by the dev_name is not really > important to consumers. In-fact, we don't even need to fill the bus_info, received a similar comment on iris [1] [1]: https://lore.kernel.org/linux-media/c4350128-a05c-47af-a7e7-2810171cd311@xs4all.nl/ Thanks, Dikshita > > ? >