From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdCMKXv (ORCPT ); Mon, 13 Mar 2017 06:23:51 -0400 Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:44752 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdCMKXm (ORCPT ); Mon, 13 Mar 2017 06:23:42 -0400 Subject: Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue To: "Wu, Songjun" , Colin King , Mauro Carvalho Chehab , linux-media@vger.kernel.org References: <20170307143047.30082-1-colin.king@canonical.com> <5dc9d025-31d5-b129-09df-5de19758e886@microchip.com> <144915d3-b386-78c2-d4d8-3410c70348ff@microchip.com> <2058665c-5ed6-5dfa-b96e-3c0579b8e6df@microchip.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans Verkuil Message-ID: <35de6fac-71ae-b8b2-126a-b4e702cf52f1@xs4all.nl> Date: Mon, 13 Mar 2017 11:23:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2058665c-5ed6-5dfa-b96e-3c0579b8e6df@microchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2017 10:32 AM, Wu, Songjun wrote: > > > On 3/13/2017 17:25, Hans Verkuil wrote: >> On 03/13/2017 06:53 AM, Wu, Songjun wrote: >>> >>> >>> On 3/9/2017 18:57, Hans Verkuil wrote: >>>> Hi Songjun, >>>> >>>> On 08/03/17 03:25, Wu, Songjun wrote: >>>>> Hi Colin, >>>>> >>>>> Thank you for your comment. >>>>> It is a bug, will be fixed in the next patch. >>>> >>>> Do you mean that you will provide a new patch for this? Is there anything >>>> wrong with this patch? It seems reasonable to me. >>>> >>> Hi Hans, >>> >>> I see this patch is merged in git://linuxtv.org/media_tree.git. >>> So I do not need submit isc-pipeline-v3 patch, just submit the patches, >>> based on the current master branch? >> >> Huh? Where do you see that this patch is merged? I don't see it in the media_tree master >> branch. >> > Hi Hans, > > I see this patch on the master branch in media_tree. > https://git.linuxtv.org/media_tree.git/tree/drivers/media/platform/atmel/atmel-isc.c ??? That's a link to the source, not a patch. And that source still does <= HIST_ENTRIES. Still confused, Hans > >> Regards, >> >> Hans >> >>> >>>> Regards, >>>> >>>> Hans >>>> >>>>> >>>>> On 3/7/2017 22:30, Colin King wrote: >>>>>> From: Colin Ian King >>>>>> >>>>>> The are only HIST_ENTRIES worth of entries in hist_entry however the >>>>>> for-loop is iterating one too many times leasing to a read access off >>>>>> the end off the array ctrls->hist_entry. Fix this by iterating by >>>>>> the correct number of times. >>>>>> >>>>>> Detected by CoverityScan, CID#1415279 ("Out-of-bounds read") >>>>>> >>>>>> Signed-off-by: Colin Ian King >>>>>> --- >>>>>> drivers/media/platform/atmel/atmel-isc.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c >>>>>> index b380a7d..7dacf8c 100644 >>>>>> --- a/drivers/media/platform/atmel/atmel-isc.c >>>>>> +++ b/drivers/media/platform/atmel/atmel-isc.c >>>>>> @@ -1298,7 +1298,7 @@ static void isc_hist_count(struct isc_device *isc) >>>>>> regmap_bulk_read(regmap, ISC_HIS_ENTRY, hist_entry, HIST_ENTRIES); >>>>>> >>>>>> *hist_count = 0; >>>>>> - for (i = 0; i <= HIST_ENTRIES; i++) >>>>>> + for (i = 0; i < HIST_ENTRIES; i++) >>>>>> *hist_count += i * (*hist_entry++); >>>>>> } >>>>>> >>>>>> >>>> >>