From: Sander Vanheule <sander@svanheule.net>
To: linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Sander Vanheule <sander@svanheule.net>
Subject: [RFC PATCH v1 2/3] dt-bindings: power: reset: gpio-restart: Add -ms suffix to delays
Date: Thu, 30 Dec 2021 19:06:02 +0100 [thread overview]
Message-ID: <35e4da34fb7e18ea7e3af2405db4c5a2a7ba2dfe.1640887456.git.sander@svanheule.net> (raw)
In-Reply-To: <cover.1640887456.git.sander@svanheule.net>
The delay properties are expressed in milliseconds, so the property
names should have a -ms suffix. Add the suffix, and deprecate the
original properties.
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
.../bindings/power/reset/gpio-restart.yaml | 27 ++++++++++++-------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml b/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml
index 6a1f4aeebf49..13827fe7b395 100644
--- a/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml
+++ b/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml
@@ -62,17 +62,26 @@ properties:
restart handlers
active-delay:
- $ref: /schemas/types.yaml#/definitions/uint32
- description: Delay (default 100) to wait after driving gpio active [ms]
+ $ref: '#/properties/active-delay-ms'
+ deprecated: true
inactive-delay:
- $ref: /schemas/types.yaml#/definitions/uint32
- description: Delay (default 100) to wait after driving gpio inactive [ms]
+ $ref: '#/properties/inactive-delay-ms'
+ deprecated: true
wait-delay:
- $ref: /schemas/types.yaml#/definitions/uint32
+ $ref: '#/properties/wait-delay-ms'
+ deprecated: true
+
+ active-delay-ms:
+ description: Delay (default 100 ms) to wait after driving gpio active
+
+ inactive-delay-ms:
+ description: Delay (default 100 ms) to wait after driving gpio inactive
+
+ wait-delay-ms:
description:
- Delay (default 3000) to wait after completing restart sequence [ms]
+ Delay (default 3000 ms) to wait after completing restart sequence
required:
- compatible
@@ -86,7 +95,7 @@ examples:
compatible = "gpio-restart";
gpios = <&gpio 4 0>;
priority = <128>;
- active-delay = <100>;
- inactive-delay = <100>;
- wait-delay = <3000>;
+ active-delay-ms = <100>;
+ inactive-delay-ms = <100>;
+ wait-delay-ms = <3000>;
};
--
2.33.1
next prev parent reply other threads:[~2021-12-30 18:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-30 18:06 [RFC PATCH v1 0/3] convert gpio-restart bindings to yaml Sander Vanheule
2021-12-30 18:06 ` [RFC PATCH v1 1/3] dt-bindings: power: reset: Convert gpio-restart binding to schema Sander Vanheule
2021-12-30 18:11 ` Sander Vanheule
2022-01-01 22:01 ` Rob Herring
2021-12-30 18:06 ` Sander Vanheule [this message]
2022-01-10 20:38 ` [RFC PATCH v1 2/3] dt-bindings: power: reset: gpio-restart: Add -ms suffix to delays Rob Herring
2022-01-10 20:55 ` Sander Vanheule
2021-12-30 18:06 ` [RFC PATCH v1 3/3] dt-bindings: power: reset: gpio-restart: Correct default priority Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35e4da34fb7e18ea7e3af2405db4c5a2a7ba2dfe.1640887456.git.sander@svanheule.net \
--to=sander@svanheule.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome