From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M
Date: Thu, 01 Apr 2021 10:06:47 +0200 [thread overview]
Message-ID: <35e8c3ce5d4265b4e7294b4296c60484aab6adbc.camel@ew.tq-group.com> (raw)
In-Reply-To: <20210401080437.GM2916463@dell>
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote:
> On Wed, 31 Mar 2021, Andy Shevchenko wrote:
>
> > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer
> > <matthias.schiffer@ew.tq-group.com> wrote:
> > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote:
> > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer
> > > > <matthias.schiffer@ew.tq-group.com> wrote:
> >
> > ...
> >
> > > > > + return 24000;
> > > >
> > > > AFAICS it will return 24 MHz for "Unknown" board. Is it okay to be so brave?
> > >
> > > As noted in the commit message, our hardware developers intend to use
> > > 24 MHz for all future x86 SoMs.
> >
> > What may go wrong in the future?.. (rhetorical question, obviously)
>
> My preference would be to be explicit.
>
> Rather than support boards implicitly i.e. by accident.
>
How about logging a warning for unknown boards, but still returning
24 MHz?
prev parent reply other threads:[~2021-04-01 8:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 11:35 [PATCH 0/3] tqmx86: TQMxE40M support Matthias Schiffer
2021-03-31 11:35 ` [PATCH 1/3] gpio: tqmx86: really make IRQ optional Matthias Schiffer
2021-03-31 12:29 ` Andy Shevchenko
2021-03-31 12:36 ` (EXT) " Matthias Schiffer
2021-03-31 12:39 ` Andy Shevchenko
2021-03-31 13:36 ` Matthias Schiffer
2021-03-31 14:03 ` Andy Shevchenko
2021-06-24 13:44 ` Matthias Schiffer
2021-06-27 9:23 ` Andy Shevchenko
2021-03-31 12:30 ` Andy Shevchenko
2021-03-31 11:35 ` [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set Matthias Schiffer
2021-03-31 12:35 ` Andy Shevchenko
2021-03-31 13:24 ` Matthias Schiffer
2021-03-31 14:10 ` Andy Shevchenko
2021-03-31 11:35 ` [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M Matthias Schiffer
2021-03-31 12:37 ` Andy Shevchenko
2021-03-31 13:33 ` Matthias Schiffer
2021-03-31 14:11 ` Andy Shevchenko
2021-04-01 8:04 ` Lee Jones
2021-04-01 8:06 ` Matthias Schiffer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35e8c3ce5d4265b4e7294b4296c60484aab6adbc.camel@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®