From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m15589.qiye.163.com (mail-m15589.qiye.163.com [101.71.155.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D6BF1DF748 for ; Wed, 11 Feb 2026 14:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=101.71.155.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770819648; cv=none; b=jg78CpPoxE343hhLBuqj0b43LNgUyzrydSWiFTyxrUHBOt0Yasft8zcOE1gZT7V+abxEwzzVoc4drWda2oC09e2l2rz9nqxLk0wTdMm08J2li3CSjcbjgbpADEo+Z6Ogex6wcLU5f7F7tiYdKTQDAFsFdDGun8qMfp6kRD0r4WM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770819648; c=relaxed/simple; bh=ht+12F0PR7MeyayPyvxbB69/ALXiFDtkh2l5v6fvuWE=; h=Cc:Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=oCFFxi3Lgwr9bQx0pE2A0SdfeS8T9jgfb1YI6ra0rsUcR2OU3nR7Lkw5g8iJEKQXPJYdprBTbSb6acJoln/jp3Anf9lMvagf7RiXMyLkEGMSIMPJ3etEDhZGAnF9W0gjkm0SExemU/hPP3ljtPbttfzEBt4DGS2xnTwh6Pt5/m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Jd/D6Sqq; arc=none smtp.client-ip=101.71.155.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Jd/D6Sqq" Received: from [172.16.12.14] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 33e0ed73f; Wed, 11 Feb 2026 22:20:36 +0800 (GMT+08:00) Cc: shawn.lin@rock-chips.com, quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: Re: [PATCH v2 1/4] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-jaguar To: Heiko Stuebner References: <20260210080303.680403-1-heiko@sntech.de> <20260210080303.680403-2-heiko@sntech.de> From: Shawn Lin Message-ID: <35e97a41-b88b-f526-351f-d4c5f70ee4e9@rock-chips.com> Date: Wed, 11 Feb 2026 22:20:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260210080303.680403-2-heiko@sntech.de> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9c4d134d3309cckunm6558f76d1130b4 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGU9MH1YfT09OHk5PTEtOQ0xWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=Jd/D6SqqvQ/D2crUTb0SspbNzDIKFiut0E+3WDbA/abOzfoUi9CbOdqOOIJbwKw6vfJUSXZQ38LibqNUbdgvQBdoZQdCWiDXH4agJO9R3b6QO90bSoYksEH3U3qdC0lpopMq++iBnFNaRR0kfPmQTxH2zmipkJyvNkYqCozK6/o=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=AutWd/q6ZaqPhu5uFw1JelIb15wNEG20TmOwXpnuti8=; h=date:mime-version:subject:message-id:from; Hi Heiko ÔÚ 2026/02/10 ÐÇÆÚ¶þ 16:02, Heiko Stuebner дµÀ: > From: Heiko Stuebner > > Using a combination of fixed clock and gpio-gate clock works but does > not describe the actual hardware. Use the gated-fixed-clock binding > to describe this in a nicer way. > > Signed-off-by: Heiko Stuebner > --- > .../arm64/boot/dts/rockchip/rk3588-jaguar.dts | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts > index 952affaf455c..e21ad7575cb6 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts > @@ -86,25 +86,16 @@ led-1 { > }; > }; > > - /* > - * 100MHz reference clock for PCIe peripherals from PI6C557-05BLE > - * clock generator. > - * The clock output is gated via the OE pin on the clock generator. > - * This is modeled as a fixed-clock plus a gpio-gate-clock. > - */ > - pcie_refclk_gen: pcie-refclk-gen-clock { > - compatible = "fixed-clock"; > + /* 100MHz PCIe reference clock from PI6C557-05BLE */ > + pcie_refclk: pcie-clock-generator { > + compatible = "gated-fixed-clock"; > #clock-cells = <0>; > clock-frequency = <100000000>; > - }; > - > - pcie_refclk: pcie-refclk-clock { > - compatible = "gpio-gate-clock"; > - clocks = <&pcie_refclk_gen>; > - #clock-cells = <0>; > + clock-output-names = "pcie-refclk-clock"; > enable-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; /* PCIE30X4_CLKREQN_M0 */ > pinctrl-names = "default"; > pinctrl-0 = <&pcie30x4_clkreqn_m0>; This looks fine, Reviewed-by: Shawn Lin > + vdd-supply = <&vcca_3v3_s0>; > }; > > pps { >