From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CDAC7F471 for ; Tue, 6 Feb 2024 05:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707198895; cv=none; b=XX2Arxobr2VMXvk2idJ5troXyLW/5dtDGWehR73zPYJdVMJTDyVofdP+PeM4w+G/w4wny2RnydkMjcUjzsx3q//UPENKANtYBV2qt6qbH4y2LIqkAZi7w9T5diJS9ycE7pek+0/MoPHv5nzFJsPfcYFqAQtb8wWjMfjtTlBL1fU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707198895; c=relaxed/simple; bh=wqaA3OoXDWlX//VDvJy2vgmQEdAqGqgvYRWWrJpJDUY=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=VBWRsCp2W5ai9KnV3kRwt6noCM38skWGuZo5Y+hCWZwuEJQUFBF9fqysYm1dwGMViYMWHbQU5ioyaiWhk6wsaxm1sieFhDCzkXM1gI0/1HrG2Op8pXuI3p+Y7dTbAEK1+f9yr0Ws64FqIVRmOhUmulT1sGKgBEurjTT3OMgo2Ns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=mEn0c1cQ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="mEn0c1cQ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40fc22f372cso40613815e9.1 for ; Mon, 05 Feb 2024 21:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707198890; x=1707803690; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BTY1QBAZTWEgUTJ50PFVukt0GrjEOa549/HqPP8e+bE=; b=mEn0c1cQWPKhibFG8wVRLFtXAldb88hbN6cXn07bndaX+cu+4S6S4M5cKr2PFeOLA+ wC2SVUvaYOSo/SFpu/EF/P+0ASvBhLsC/g9hYUBhLnzNxIV2f+8neF5iuNwNHxEf5ciT rMRoB+62+3ald5OcqVL5cp86QaYwZXdg6UzyE4YDR47joM0O+2inrJMdSADkOvBCkHM4 q6ItAsuLbx3QT4D0WIrR8BEx1wJY17v6LniWHfotjOPLXLc8MkR24D1maHl41Jp6tQ+X THEvuZZ2cIW4oZWeVhMwAhNZFIgZIICSvYMieYLnFrbp8Om3QElVCtfkbgxLg5k6qLBX idmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707198890; x=1707803690; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BTY1QBAZTWEgUTJ50PFVukt0GrjEOa549/HqPP8e+bE=; b=XcEDzKooW1XMGUAlu3+6/DnkJ+8qXbmb1ohk+g9N4Vxuk1FsS4fzZRWWHW4DjiZGwT EqFdOT27QbN6JXgx/fNDn6RBbB3giNKiNwcQOJbElTSS17FoW4ZXemq54Rucq/HKrqrX /S9zVD2L2fiIovZRwp/sT+MlYuW6JjhV7HJtg7csL5OjUEletjJK5HId7cfzLZHEoIkR ZxZHPr9f6AXfruYw4OsHK6a89a3aiQEiFVRsmcNU2JWQya6lPp2M9sYd7JAiVFo1EKrg K+tJE7uOnha2QjAaRvzsx3PNRpD5+2p5fIiCDoxRSf5VcZvfdQM3CVUGutadV71NuIo1 tk+Q== X-Gm-Message-State: AOJu0YycOnbuVtmwy45Ggcuyp5sbOgQ3F7i2HxpwFm7vcDwccjBTvzQ4 Tc1DYLfQFAIjbhds9HlGxTgs+msPlJ0lfssdqzBQkzNcOxyPrJQgX7Lhl4EmJMQ= X-Google-Smtp-Source: AGHT+IEvGBnActUAu0BCa5hFJpoZeCTBqeuLBV8E8iuP45AWz8rKTDXuJ8EaVdAWla8jMfh26r+E1Q== X-Received: by 2002:a05:600c:4f51:b0:40e:4806:f436 with SMTP id m17-20020a05600c4f5100b0040e4806f436mr603514wmq.3.1707198890571; Mon, 05 Feb 2024 21:54:50 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUTkORDlPYl+vANvx/D4Q9dJgi1J2wftRMmPO6f46Y5Sd4BnVKKIMqeETxDBNQDD51YT/nbeCapIEqVTzMKOPexGzt+E+SGiBfNX1kQ2Mu1o6UICao3rJqfaLREU4fvhlAgZbqoiW4l558pDeOSkkfGbXp0BJsd1r1dSHKwKUqg0ADUWSBLXaSCrRbxx+uas+g6uPvPPfs0JwoZbq+3wtQEn3+ppEtvJkHT099/XlwKGJ2tJH1roldRpXgLd5A41qoBVPM7SxFDOOj8Xvb1LyyIrum3AyA+oSFmPK9BRbpd+0/q3GLEqaPvYjgJJT9RS98sNn7gPlI7Bu85m48Tzr6LA6BrxfZAKeFXPyaWFQbfJloBFjdC+s+rbdv7OW3M+POgS0Ic6Z3KSJhEZMmPWn4T Received: from [192.168.50.4] ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id fa13-20020a05600c518d00b0040fb03f803esm741966wmb.24.2024.02.05.21.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 21:54:50 -0800 (PST) Message-ID: <35eca42a-5bb0-4d24-972b-6fe2fb4d87ab@tuxon.dev> Date: Tue, 6 Feb 2024 07:54:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] ARM: dts: microchip: sam9x60ek: Add power-supply properties for sdmmc nodes Content-Language: en-US To: Mihai Sain , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240205080027.4565-1-mihai.sain@microchip.com> <20240205080027.4565-3-mihai.sain@microchip.com> From: claudiu beznea In-Reply-To: <20240205080027.4565-3-mihai.sain@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Mihai, On 05.02.2024 10:00, Mihai Sain wrote: > The sdmmc0 and sdmmc1 controllers are powered from 3.3V regulator. > Add vmmc-supply and vqmmc-supply properties to sdmmc nodes. > The sdmmc controller from SAM9X60 MPU doesn't support the IO voltage signaling/switching required by the UHS sd-card. Please wrap the line at 75 chars (see [1]). Thank you, Claudiu Beznea [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#the-canonical-patch-format. > In order to use the sd high-speed mode, keep vqmmc at 3V3. > > Signed-off-by: Mihai Sain > --- > arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > index f3cbb675cea4..b19a0956dc97 100644 > --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > @@ -560,6 +560,8 @@ &sdmmc0 { > status = "okay"; > cd-gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > disable-wp; > + vmmc-supply = <&vdd1_3v3>; > + vqmmc-supply = <&vdd1_3v3>; > }; > > &sdmmc1 { > @@ -568,6 +570,8 @@ &sdmmc1 { > pinctrl-0 = <&pinctrl_sdmmc1_default>; > no-1-8-v; > non-removable; > + vmmc-supply = <&vdd1_3v3>; > + vqmmc-supply = <&vdd1_3v3>; > status = "disabled"; /* Conflict with flx4. */ > }; >