From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbdB1OFc (ORCPT ); Tue, 28 Feb 2017 09:05:32 -0500 Received: from foss.arm.com ([217.140.101.70]:37538 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdB1OF3 (ORCPT ); Tue, 28 Feb 2017 09:05:29 -0500 Subject: Re: [PATCH] usb: gadget: configs: plug memory leak To: John Keeping , Felipe Balbi References: <20170228105530.5485-1-john@metanate.com> Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Suzuki K Poulose Message-ID: <35f3e080-f3b8-be4a-4304-335fe4d15cae@arm.com> Date: Tue, 28 Feb 2017 13:54:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170228105530.5485-1-john@metanate.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/17 10:55, John Keeping wrote: > When binding a gadget to a device, "name" is stored in gi->udc_name, but > this does not happen when unregistering and the string is leaked. > > Signed-off-by: John Keeping > --- > drivers/usb/gadget/configfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index 78c44979dde3..cbff3b02840d 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -269,6 +269,7 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item, > ret = unregister_gadget(gi); > if (ret) > goto err; > + kfree(name); Looks correct to me. Suzuki