mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ronak Jain" <ronak.jain@amd.com>,
	"Michal Simek" <michal.simek@amd.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	sai.krishna.potthuri@amd.com, "Tanmay Shah" <tanmay.shah@amd.com>,
	"Ben Levinsky" <ben.levinsky@amd.com>,
	nava.kishore.manne@amd.com, "Rob Herring" <robh@kernel.org>,
	dhaval.r.shah@amd.com, "Marek Vasut" <marex@denx.de>,
	"Roman Gushchin" <roman.gushchin@linux.dev>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	shubhrajyoti.datta@amd.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xilinx: firmware: Add sysfs to get last reset reason
Date: Tue, 21 Nov 2023 13:30:30 +0100	[thread overview]
Message-ID: <35f4c415-1d26-447f-91bd-eb192201c998@app.fastmail.com> (raw)
In-Reply-To: <20231121112056.1762641-3-ronak.jain@amd.com>

On Tue, Nov 21, 2023, at 12:20, Ronak Jain wrote:
> Add sysfs interface to get the last reset reason of the system from
> a user space.
>
> When the system reset happens whether intentionally or due to some
> errors, the firmware used to store the last reset reason and the same
> be queried by using the IOCTL API or the sysfs entry to know the
> reason behind the system reset and accordingly, the error can be
> diagnostic.
>
> Signed-off-by: Ronak Jain <ronak.jain@amd.com>

I'm fairly sure we already have other interfaces to access
the reset reason, please see if you can either reuse one
of the existing ones, or come up with a generic one that
can be used by others as well.

      Arnd

  reply	other threads:[~2023-11-21 12:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 11:20 [PATCH 0/2] Add support for " Ronak Jain
2023-11-21 11:20 ` [PATCH 1/2] firmware: xilinx: Add support for GET_LAST_RESET_REASON IOCTL Ronak Jain
2023-11-21 11:20 ` [PATCH 2/2] xilinx: firmware: Add sysfs to get last reset reason Ronak Jain
2023-11-21 12:30   ` Arnd Bergmann [this message]
2023-11-29 11:53     ` Jain, Ronak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35f4c415-1d26-447f-91bd-eb192201c998@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=ben.levinsky@amd.com \
    --cc=dhaval.r.shah@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=mathieu.poirier@linaro.org \
    --cc=michal.simek@amd.com \
    --cc=nava.kishore.manne@amd.com \
    --cc=robh@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=ronak.jain@amd.com \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=tanmay.shah@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®