From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 379C4314A9D for ; Mon, 19 Jan 2026 12:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825507; cv=none; b=rQebyiYeBwMXGc7H6vr7YRP/dONp8fHO/sAw7Khor0AA/FySMJtCf3LL//gXy3I8X40is1qZ91jBUprOR4a51sPaafEk+qQfIJA+of5JtAFx28ccMP+sFBpXFTijOtMsUws7YbF4nbydc8gT0mJEbG1nKdfYDNhAUvz7XvkRShM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768825507; c=relaxed/simple; bh=1mpdSpB42HOH+CED4/BNQ3DTpRvK+xQjYmsHPbum8OA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qopgT6b3fMip13AbRb5sZ5W5zTLdkpEjpp+QRRN4dNJbRTLajWoJpL2rUczTKxFBVJ47xORr32A6lbQ1kkvACAofUfCiEUidOYx1aLz+4hA5J6WWAG11BBIYoboXIE/WpN21sVOBPoAnqSQDji9ecns8F7entaz7L3XChBbMDu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=G568nbUz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MrZeDa+c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="G568nbUz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MrZeDa+c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60JA7YQH597706 for ; Mon, 19 Jan 2026 12:25:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AS4+y5Ixt5ikr4pYFKf10f+qp8yuyDl61gKWxxUFT6k=; b=G568nbUz3mTLaxzL fvKXILX8yDmVLj8GAkG5rA7IscY1QEbXGXjd1uwfjOmcL15avGUcK4nUVAaDo0ye WAQNUwdXnjylWQtjLotCVPuFYtuVFmMv8faSuH1YnILIhSGUmdzU1DI4PK+bxtm0 Cz/Ioqya8TnrEMgbmHu1pK4L1S1C0mxC8YmjZVNl6uTyzkjO6k/Lc2OEAT72bwIo fDJBbkJv1pRIqJfxVDTQYM9Qxi0VD4SwaU/pdvxbEvMBIBNw0ys0BmMKSxFbdwVU 7Nwek3Cc74F3hxYMBF71nlq4pIRHxMYHefPnnnd3gth3yZk94miW0FUAZCbJIJTV HjFJrg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bsjk7gcy8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 12:25:02 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8888ae5976aso17454606d6.2 for ; Mon, 19 Jan 2026 04:25:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768825502; x=1769430302; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AS4+y5Ixt5ikr4pYFKf10f+qp8yuyDl61gKWxxUFT6k=; b=MrZeDa+cf0soY7ZJ4Eb+Ue8SF7yAaacWqocRIGvZ9CgciLdnXUMKzuof+EPlucUiPd ibA4cfM6Y8aYZFRMJQ6x3gqmFys/U4edkPjLcV/+DrHlbU+NKfMfVnC1LikoG1ysQ3Vk wNWzf7vhlUL3CSSUg7fDEv5to8jZDvtJIzzjDxMtyqDKFdOBAU2dB7/E9gBsOaH8n+ww N8RtoC1UQNs8ZCgyADTD8NmvpMonio1NkzKMylt5iO/OehzdHGAtGWv1STb0VloCWYYV dNRJSERSOxWBa+DHIEYPbWnb8aszp4xj/MRAhR89sNIuXlLzAO3wZk9A/CbC6wHBGdn6 DtmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768825502; x=1769430302; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AS4+y5Ixt5ikr4pYFKf10f+qp8yuyDl61gKWxxUFT6k=; b=u0Bs9RbK9TJcM179s7QqTP4zx1TAQ+CfmGYFbSlxxofT81MdFrP0Nq5V9+Yqa4EOKP hMpn/P54AWw9No1ylGKxgSb8OwazkmMqyOoQiUj0Q03oV3UX1zDZV2n4dtz0EWpC16UO mMMdpVrJNGxLkoKqC2cBlMHq0srtn/rEDBCEhMZgAatVknx7FMCoAYaEGonzgjEk47Sc jlLpJS6bZ6ry3DTKEvi9ODX0+1kiJVPaSHzpSgejZd3LfUQmELvpbjSWxaSYjXU7qQSK bmyQQt0alxcZIQ2J7LF9Ql6nMWE0j6/SRvlpKwUY8afvuPVAtSB0JCMeZ6ymQrHWeHlh abrA== X-Forwarded-Encrypted: i=1; AJvYcCUEhwqLO2a5ijJ1aGocWHaQNqK75p+jsuBmgr4SSiOpEcQK+AMgvKCVlPp+6agJqWILGu2ta9l+ZbyUru0=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ8q+1JBygKx4+rzdZH+34orurWu/Vh90rjPI18BBPZZs+R+CI MpiPZbQ52V353aQcpG4oeu4zhC1Mz0ab0eWDRqymO/1K5esHGiKatw6xivng/UlQl1DhNrMBSEo wXhrBPKK0xFb+7huwdibHaa/svAr0paoYdiRRLxk3bmQUgJxTKgbgqN1+enSBxXLEpys= X-Gm-Gg: AY/fxX6LFHE2GKmS6sDKz38O8uDns2R5Xu4w6ur6J29O8WPNOk0vHQoXRXegITxu/ku PYN1iML7TK1Y4nUS8RTlg0M09wBJk8jaUUQcG844ZaLhCBB+/b9iTLomKLa2qHOH+d1WITgUXRj iNi4587wkixuvjPhQEVQzV1Dvq72wonfP+OWUFH7NTUn337AtLhbQsDhAhN/s1dsQVhJmTDeB0e n6+tr2VxO9X7PJMtZCbIoYAaBl7dkfXow3gHtHlH8sBaN+FaE9GEAsLNUfFHbxBGqwvoKePXKab nuh6AynPKRL5tYMDJRd2Bj4JeKRd1qbF+UTA9XzWy5jFJygQr+u3GmYdWHbRfuVtOC7CtoLtKO9 SwfSsbZVIXFr2d1vycM5ohDyVZoajkcIlAVCuUelT5kbMoYrI6cpZs1HlYjoMwiHcFaY= X-Received: by 2002:a05:620a:2947:b0:8b2:ec2f:cb3d with SMTP id af79cd13be357-8c6a67cb0bbmr1154159985a.10.1768825501867; Mon, 19 Jan 2026 04:25:01 -0800 (PST) X-Received: by 2002:a05:620a:2947:b0:8b2:ec2f:cb3d with SMTP id af79cd13be357-8c6a67cb0bbmr1154156385a.10.1768825501296; Mon, 19 Jan 2026 04:25:01 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b87959c9fbbsm1114310366b.38.2026.01.19.04.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 04:25:00 -0800 (PST) Message-ID: <35fababe-11ec-48a8-a6a1-d1aa1ab95dca@oss.qualcomm.com> Date: Mon, 19 Jan 2026 13:24:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/4] drm/msm/dpu: fix SSPP_UBWC_STATIC_CTRL programming on UBWC 5.x+ To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Vinod Koul , Stephan Gerhold Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Val Packett References: <20260119-msm-ubwc-fixes-v4-0-0987acc0427f@oss.qualcomm.com> <20260119-msm-ubwc-fixes-v4-4-0987acc0427f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260119-msm-ubwc-fixes-v4-4-0987acc0427f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDEwMiBTYWx0ZWRfX22WtovBFR52G ZWy+PwVo/qp6CT+pgXe4SeXMWXPTNfN5w3K4oSO3kB01gHHk6PXT/8prundSBsPUiowvv1Do+hW Nm6aNpjmFwG0XCSXmHDQGb8FvlYTVcBDRPH06cDW+66qyul9yIT3NtjL5pqVYofaSDfHy4sM8zU fuqeN7CIBcA7lm6W4rWK48gxJFlwmNel8svE5GC6OI1EN8T3fselnEtzBSap4zes5UupVeFmv0n lVpbbOkfLPipvJ4zCS6e8S0Z7+fQOdbQQp3Z5x1bbZ3mBiJl1522V8jgpDlodDjTe1wDDQOoGxF 3G3NbsLM92p/N0GXP4A5sd1elEqf30nHVLcqnLIxABMr80X/MgfR10bgkevWwLVT+XiFNbxKmms u2u01o4eTOMFHp0tOGoCyMc1pq67RPF6fkxLKWnxQlXA9ceKYOv0rgeBD6MfEVFnAcCkopxf1y2 930FYsyjaG6g0rTz+Jw== X-Proofpoint-ORIG-GUID: gaQ-U0XbqDjKAf75DctDdccVcBdbG5XY X-Authority-Analysis: v=2.4 cv=WoAm8Nfv c=1 sm=1 tr=0 ts=696e229e cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=s51bjNJNeX3feSWTtREA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: gaQ-U0XbqDjKAf75DctDdccVcBdbG5XY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-19_02,2026-01-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190102 On 1/19/26 1:16 PM, Dmitry Baryshkov wrote: > Code in dpu_hw_sspp_setup_format() doesn't handle UBWC versions bigger > than 4.0. Replace switch-case with if-else checks, making sure that the > register is initialized on UBWC 5.x (and later) hosts. > > Fixes: c2577fc1740d ("drm/msm/dpu: Add support for SM8750") > Tested-by: Val Packett # x1e80100-dell-latitude-7455 > Signed-off-by: Dmitry Baryshkov > --- [...] > + if (ctx->ubwc->ubwc_enc_version == UBWC_1_0) { > fast_clear = fmt->alpha_enable ? BIT(31) : 0; > - DPU_REG_WRITE(c, ubwc_ctrl_off, > - fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | > - BIT(8) | > - (hbb << 4)); > - break; > - case UBWC_2_0: > + ctrl_val = fast_clear | (ctx->ubwc->ubwc_swizzle & 0x1) | > + BIT(8) | (hbb << 4); > + } else if (ctx->ubwc->ubwc_enc_version == UBWC_2_0) { > fast_clear = fmt->alpha_enable ? BIT(31) : 0; > - DPU_REG_WRITE(c, ubwc_ctrl_off, > - fast_clear | (ctx->ubwc->ubwc_swizzle) | > - (hbb << 4)); > - break; > - case UBWC_3_0: > - DPU_REG_WRITE(c, ubwc_ctrl_off, > - BIT(30) | (ctx->ubwc->ubwc_swizzle) | > - (hbb << 4)); > - break; > - case UBWC_4_0: > - DPU_REG_WRITE(c, ubwc_ctrl_off, > - MSM_FORMAT_IS_YUV(fmt) ? 0 : BIT(30)); > - break; > + ctrl_val = fast_clear | ctx->ubwc->ubwc_swizzle | (hbb << 4); > + } else if (ctx->ubwc->ubwc_enc_version == UBWC_3_0) { > + ctrl_val = BIT(30) | (ctx->ubwc->ubwc_swizzle) | (hbb << 4); This is pre-existing, but BIT(30) is not unconditional in SDE for v3 For this patch Reviewed-by: Konrad Dybcio Konrad