From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932471AbcIAKTy (ORCPT ); Thu, 1 Sep 2016 06:19:54 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:53609 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984AbcIAKTx (ORCPT ); Thu, 1 Sep 2016 06:19:53 -0400 Subject: Re: [PATCH 1/2] ARM: dts: exynos: Fix mismatched value for SD4 pull up/down configuration on exynos4210 To: Krzysztof Kozlowski , Arnd Bergmann , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1472719022-27226-1-git-send-email-k.kozlowski@samsung.com> Cc: Bartlomiej Zolnierkiewicz From: Javier Martinez Canillas Message-ID: <35fb6718-aa5a-bb72-be3f-a44fab0c5aef@osg.samsung.com> Date: Thu, 1 Sep 2016 12:19:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472719022-27226-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 09/01/2016 10:37 AM, Krzysztof Kozlowski wrote: > The pinctrl pull up/down register on exynos4210 is 2-bit wide for each > pin and it accepts only values of 0, 1 and 3. The pins sd4-bus-width8 > were configured with value of 4. The driver does not validate the value > so this overflow effectively set a bit 1 in adjacent pins thus > configuring them to pull down. > > The author's intention was probably to set drive strength of 4x. All > other bus-widths pins are configured with pull up and drive strength of > 4x. Fix this one with same pattern. > > Fixes: 87711d8c7c70 ("ARM: dts: Add pinctrl node entries for SAMSUNG EXYNOS4210 SoC") > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America