From: "Vitaliy Ivanov" <vitalivanov@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>
Cc: "Andrew Morton" <akpm@osdl.org>,
"kernel list" <linux-kernel@vger.kernel.org>,
marcel@holtmann.org, maxk@qualcomm.com,
linux-bluetooth@vger.kernel.org
Subject: Re: hci_usb: remove macro code obfuscation
Date: Wed, 16 Apr 2008 13:51:37 +0300 [thread overview]
Message-ID: <35fbaa3e0804160351g1795b47bh6dbb2c8d596d0129@mail.gmail.com> (raw)
In-Reply-To: <20080416104257.GA1621@elf.ucw.cz>
On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>
> I had trouble figuring out what the code does. atomic_inc/dec
> management is actually pretty simple, but it is needlessly obfuscated
> with macros. Fix that.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> I had trouble figuring out what the code does. atomic_inc/dec
> management is actually pretty simple, but it is needlessly obfuscated
> with macros. Fix that.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
Got it from the first time;)
Do you think that now code looks better? As for me it's not...
V>
next prev parent reply other threads:[~2008-04-16 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 10:42 Pavel Machek
2008-04-16 10:51 ` Vitaliy Ivanov [this message]
2008-04-16 10:58 ` Pavel Machek
2008-04-16 17:19 ` Max Krasnyanskiy
2008-04-19 16:18 ` Pavel Machek
2008-04-16 18:29 ` Andrew Morton
2008-04-16 18:37 ` Max Krasnyanskiy
2008-04-16 20:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35fbaa3e0804160351g1795b47bh6dbb2c8d596d0129@mail.gmail.com \
--to=vitalivanov@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=maxk@qualcomm.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome