From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABF4C43331 for ; Fri, 12 Mar 2021 10:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4FE064FE2 for ; Fri, 12 Mar 2021 10:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233383AbhCLKUg (ORCPT ); Fri, 12 Mar 2021 05:20:36 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:13912 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233115AbhCLKUT (ORCPT ); Fri, 12 Mar 2021 05:20:19 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4Dxhc34xlVzjVY0; Fri, 12 Mar 2021 18:18:43 +0800 (CST) Received: from [10.67.102.248] (10.67.102.248) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 12 Mar 2021 18:20:03 +0800 Subject: Re: [PATCH] perf annotate: Fix sample events lost in stdio mode To: Namhyung Kim CC: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Yao Jin , , , linux-kernel , References: <20210306082859.179541-1-yangjihong1@huawei.com> <53ff575f-1fcf-6650-76ad-a0304f6bdf15@huawei.com> <02146240-e532-1c52-0589-bfff3fbe5166@huawei.com> From: Yang Jihong Message-ID: <360667d9-f0cc-866c-b0b9-b37dd85a9c45@huawei.com> Date: Fri, 12 Mar 2021 18:20:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.248] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2021/3/12 16:39, Namhyung Kim wrote: > On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong wrote: >> >> >> Hello, >> On 2021/3/12 13:49, Namhyung Kim wrote: >>> Hi, >>> >>> On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: >>>> >>>> Hello, Namhyung >>>> >>>> On 2021/3/11 22:42, Namhyung Kim wrote: >>>>> Hi, >>>>> >>>>> On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong wrote: >>>>>> >>>>>> Hello, >>>>>> >>>>>> On 2021/3/6 16:28, Yang Jihong wrote: >>>>>>> In hist__find_annotations function, since have a hist_entry per IP for the same >>>>>>> symbol, we free notes->src to signal already processed this symbol in stdio mode; >>>>>>> when annotate, entry will skipped if notes->src is NULL to avoid repeated output. >>>>> >>>>> I'm not sure it's still true that we have a hist_entry per IP. >>>>> Afaik the default sort key is comm,dso,sym which means it should have a single >>>>> hist_entry for each symbol. It seems like an old comment.. >>>>> >>>> Emm, yes, we have a hist_entry for per IP. >>>> a member named "sym" in struct "hist_entry" points to symbol, >>>> different IP may point to the same symbol. >>> >>> Are you sure about this? It seems like a bug then. >>> >> Yes, now each IP corresponds to a hist_entry :) >> >> Last week I found that some sample events were missing when perf >> annotate in stdio mode, so I went through the annotate code carefully. >> >> The event handling process is as follows: >> process_sample_event >> evsel_add_sample >> hists__add_entry >> __hists__add_entry >> hists__findnew_entry >> hist_entry__new -> here allock new hist_entry > > Yeah, so this is for a symbol. > >> >> hist_entry__inc_addr_samples >> symbol__inc_addr_samples >> symbol__hists >> annotated_source__new -> here alloc annotate soruce >> annotated_source__alloc_histograms -> here alloc histograms > > This should be for each IP (ideally it should be per instruction). > >> >> By bugs, do you mean there's something wrong? > > No. I think we were saying about different things. :) > OK, :) > >>>>> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c >>>>> index a23ba6bb99b6..a91fe45bd69f 100644 >>>>> --- a/tools/perf/builtin-annotate.c >>>>> +++ b/tools/perf/builtin-annotate.c >>>>> @@ -374,13 +374,6 @@ static void hists__find_annotations(struct hists *hists, >>>>> } else { >>>>> hist_entry__tty_annotate(he, evsel, ann); >>>>> nd = rb_next(nd); >>>>> - /* >>>>> - * Since we have a hist_entry per IP for the same >>>>> - * symbol, free he->ms.sym->src to signal we already >>>>> - * processed this symbol. >>>>> - */ >>>>> - zfree(¬es->src->cycles_hist); >>>>> - zfree(¬es->src); >>>>> } >>>>> } >>>>> } >>>>> >>>> This solution may have the following problem: >>>> For example, if two sample events are in two different processes but in >>>> the same symbol, repeated output may occur. >>>> Therefore, a flag is required to indicate whether the symbol has been >>>> processed to avoid repeated output. >>> >>> Hmm.. ok. Yeah we don't care about the processes here. >>> Then we should remove it from the sort key like below: >>> >>> @@ -624,6 +617,7 @@ int cmd_annotate(int argc, const char **argv) >>> if (setup_sorting(annotate.session->evlist) < 0) >>> usage_with_options(annotate_usage, options); >>> } else { >>> + sort_order = "dso,symbol"; >>> if (setup_sorting(NULL) < 0) >>> usage_with_options(annotate_usage, options); >>> } >>> >>> >> Are you referring to this solution? >> --- a/tools/perf/builtin-annotate.c >> +++ b/tools/perf/builtin-annotate.c >> @@ -374,13 +374,6 @@ static void hists__find_annotations(struct hists >> *hists, >> } else { >> hist_entry__tty_annotate(he, evsel, ann); >> nd = rb_next(nd); >> - /* >> - * Since we have a hist_entry per IP for the same >> - * symbol, free he->ms.sym->src to signal we already >> - * processed this symbol. >> - */ >> - zfree(¬es->src->cycles_hist); >> - zfree(¬es->src); >> } >> } >> } >> @@ -624,6 +617,7 @@ int cmd_annotate(int argc, const char **argv) >> if (setup_sorting(annotate.session->evlist) < 0) >> usage_with_options(annotate_usage, options); >> } else { >> + sort_order = "dso,symbol"; >> if (setup_sorting(NULL) < 0) >> usage_with_options(annotate_usage, options); >> } >> It seems to be a better solution without adding new member. >> I just tested it and it works. >> >> If we decide to use this solution, I'll resubmit a v3 patch. > > I prefer changing the sort order (and removing the zfree and comments). > OK, I'll submit a v3 patch based on the "changing the sort order" solution. Thanks, Yang > Thanks, > Namhyung > . >