From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6EAD1A08AF for ; Tue, 7 Apr 2026 02:36:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775529421; cv=none; b=F/vXc5oNI4r+DcnCUKwXiEyxVWj/dlDEUqZLEJFgu2a/dchy6QQncbMmies8rpG0pqAQ9mo7vvkDNU23dJ6wPbpWBhC2ZzGVWb3k0ta3BsrTxGZVQQg57FojXBj+55abJ6Y4UVokyArt3EzsKA64hWwIrywEkwq5exusYEGUodU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775529421; c=relaxed/simple; bh=DGR6js0kmt7+9FkSmOJhyy2G4lgDVyq4gXa3+N5f53s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aVzMiEbano7CtV734ZxopLG8YpfC3bqAqdnDvdEeOEE5uQmVPGUKSgI99SewUCc3YcPVc3P0s+TQ8GW+dGaXDExCDZUjpvafnzkYq5d0EkWQUCpUH/MFs3FnjxGOsxpA7oITneduY/rn+xFbKy0g5OBeAar/vrD6gGWXeCqrX+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jD+BQQVS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UKcG34tC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jD+BQQVS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UKcG34tC" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LQhdw3402500 for ; Tue, 7 Apr 2026 02:36:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rP7QNfv6ha6cStrz92Y08u5fmQ49YKBVYPbtSOrnZ24=; b=jD+BQQVS01zRWx0D eBPsx140V6CnvnmituvAg97pVj1XVAmwswzXr7b8HsLE+jYs46s9LeKoiuYrInqN bnMznjcIlNmdBOiztIFMSrbmNRws8wHhTjfHGfsIG/UbnIqHa1trwJBoGq8NKL9l x0gkR7Xj4+wSZgHJjLPanf91MkDwVzH86hQhAB0CkFd4baxj6QQlDPiJwaNlxzJU q6nOfhPXRnpW18FlPfBdeslGdPjFEIWfbm1PgVtB8Hx2DNM6De6wbo0VucgHHIRj sEmFEH2uYYk95qH1aME+9RQzQVl1e6lqb1Z59aYrNOUgUa/n+BVO9mobhSICIjuc UF/kyg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcmrhrp2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 02:36:57 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35d90c7ec5aso11544481a91.2 for ; Mon, 06 Apr 2026 19:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775529417; x=1776134217; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rP7QNfv6ha6cStrz92Y08u5fmQ49YKBVYPbtSOrnZ24=; b=UKcG34tCp+2/YjCZwnfO7M6qsoiOZzX6T//X7m3thWkhh9kMajSp+M4KR0KMY82nB7 4HrrY4itfcpUOdhPt6IO0GDuBPO2r63sPn2JJw7S+qOrQROjSQODKsni7vNjWln5Wn/Y AzaeOc51g7P8MP5ynpZMqBEqYDp0v96VnSC3bfadChANRsUCG547f928u3+7dfUK0tzL qgsGzCJwbAHoxySTMczScKb6F/hC0n1Iz4lsnYZkheguQxozoa+JmjdmDCStWDFZk08D Ey3j5cWihicf516xb5Yu03yIKy0OdC2eqANt97JV6xJSyK3uA2SnyYYeUQ29BazFp/CR cavA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775529417; x=1776134217; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rP7QNfv6ha6cStrz92Y08u5fmQ49YKBVYPbtSOrnZ24=; b=Ncgj6p5mNlGO84IHGETWnRIgeMOIoNt6PkeR9cUhKvnDou3BStT2REQl+OH0BiGXY2 zRtG1tfw4Wmdk85TRqwHr6qLScA8MJLWknvPEfxBiEp7IlglrpdAAcLGY38Tn57xX1Jq ius3my1KpH7BTMupwdA3MJq9x8hzOYnw/Nx9mP3053W55SUptVCTIXkN4yzehrRbv4Vi liz2ao1IBugykDQjbGCUpcMoaHZ0UBQ3fNIsIpgj3hWCLzhdyR9YAnn0yJAKmFNIB9Ve mQqBpSp72kZNB6nfEvHP/oYsStT+G1irPLGzfmdbMW9Xm5aVtCEh96+QPtigse7lkqoC Qq7Q== X-Forwarded-Encrypted: i=1; AJvYcCV9cMwPKcl1pVBCjbYr+A6u2NkSGlVshMGN0fx6uq64eMmVlpmeJ2hMs7o0pT5vr1yVcLVA/zdmNJkEoA4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0lxd/98U8UMxVjVYVyxfy6jzCFs4gryqWhq3Rbo53cnX/w3Hz jL32SxxKh51dtE3Bmuu+JZWsVM/Okqx2w9HJaZq4RxEqjDHrkX6Y37cdTX7eb3C/Bz7RzJRhlgN PwcRvVkpKroFY0DEVKN7HAHT3y6wNA81drKXUulqI9P7i9jO/KdXTt4mrbRPDJi8mvn8= X-Gm-Gg: AeBDieu8+Rx4cvt/LbPT4GWOxlGOOM83wHakB6CF+Z3s5PdE2MBTBg9XuiD4f6JGZs8 mBrEhGOBQtca9rs3BMRhEivNGQF6gCPh9yrXcjo/K2YWMkmoXuYeHGnmagYCgpyPlF7xgn7MKiA VRaPOv29MYlVa0ITFdzqauYtm1bygULEHjDzP4v3hDwxkeNxrhxZGfmMDRxpdbZV/dkdh0qHRLM Y2+uNbeJk304Wt9MGffg89l/5RaHeViIPtTAiU9lxaml9mA1GOYrHAI5AGGO4yNeiJ1BgVmn5GD eQqOFKjUzI2dBaItGwlqOs8v8/xjE9JJGgk5Ezpl3+eyDEOYGTpZKdgTjYPxVGJv//Cu+qh/S7m LSuFeV46TWlaUYKtfZpO+qgg8msyZvawjQSkuoQpoDbKr7hLUl8UOkI7RdNft3b9BwfXOl+o2M1 x579HLQvYMIfTOJE9P+Q== X-Received: by 2002:a17:90b:3851:b0:35d:9d4f:f58a with SMTP id 98e67ed59e1d1-35de67df975mr14429975a91.9.1775529416683; Mon, 06 Apr 2026 19:36:56 -0700 (PDT) X-Received: by 2002:a17:90b:3851:b0:35d:9d4f:f58a with SMTP id 98e67ed59e1d1-35de67df975mr14429947a91.9.1775529416223; Mon, 06 Apr 2026 19:36:56 -0700 (PDT) Received: from [10.133.33.129] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35de51710eesm4244919a91.1.2026.04.06.19.36.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 19:36:55 -0700 (PDT) Message-ID: <360d6087-2907-4db2-9273-c3ecc39ffb12@oss.qualcomm.com> Date: Tue, 7 Apr 2026 10:36:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 33/38] drm/msm: add support for MST non-blocking commits To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-33-01faacfcdedd@oss.qualcomm.com> <56tbubd46myozsycduvb5ds26smzosydr5fmbvmlv6yoiqt5wr@3ib5gnspxxqa> Content-Language: en-US From: Yongxing Mou In-Reply-To: <56tbubd46myozsycduvb5ds26smzosydr5fmbvmlv6yoiqt5wr@3ib5gnspxxqa> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDAyMyBTYWx0ZWRfX2XYC+TGltq4v RmITY+/pmEIurr3bID3JhPfqVJzsIao52McBuFAuecqzACNovTRxj65sGz9iKe0vx6zEhgN48rS 4pw0dlmRc8dS9L0smm1ABuIyWdDWiJS5gIDLK2DGU3zxTz5+YUmAQ2rUYK001lC+1xQT/XCV7i7 a0R723CFxqKS0MtO8eOVAp/YNl7TJU9X7Q9xdwH1PYQjbd3Jju8NHEHuMowf41FIfpI1EF7iKTb EDP3Ctro0RpY8s5hHK1dDQw8hjIfp++QSGQ2Fk67bhQ0I0tneeyoTNXYRog0qaLQ+LYJtenB7H7 Krn2wiRc2P8XvMBBu6Sr4RG7hu23DT4vAhg/GEMIY3cwYBrroPhmRiZf1w/J/UoXsAz0TN7Fn4g caBuDwfXKxxCs9wW9rnsXs/PDR1+Qi0Y1s6ghsir64Th5vm+GVbFfSFOFM2TKVG+SxXUICysi0E Ny7FNxURMtL9M3p3GFA== X-Proofpoint-GUID: XMHdIcThJh91NFFmJhA7of2xRvAmopyC X-Authority-Analysis: v=2.4 cv=XPUAjwhE c=1 sm=1 tr=0 ts=69d46dc9 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=v9bGeqcMFpeTl9iv2AIA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: XMHdIcThJh91NFFmJhA7of2xRvAmopyC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_01,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070023 On 8/27/2025 2:47 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:16:19PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> Integrate MST framework APIs with atomic_commit_setup() and >> atomic_commit_tail() to support non-blocking atomic commits >> for DisplayPort MST. >> >> This patch only applies to MST. For SST, non-blocking commits are >> already handled via commit_tail(), which internally calls >> drm_atomic_helper_wait_for_dependencies() in the DRM core. > > I think this should be squashed into the the commit adding MST > atomic_check call. > > Otherwise: > > > Reviewed-by: Dmitry Baryshkov > > Will merge 2 patches.. Thanks. > >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/msm_atomic.c | 3 +++ >> drivers/gpu/drm/msm/msm_kms.c | 2 ++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c >> index 3aa0020dec3a90b693ad3d4171cfcffc091aad4c..b1656fb456d54af11ba8a30d4971fface114c7a1 100644 >> --- a/drivers/gpu/drm/msm/msm_atomic.c >> +++ b/drivers/gpu/drm/msm/msm_atomic.c >> @@ -4,6 +4,7 @@ >> * Author: Rob Clark >> */ >> >> +#include >> #include >> #include >> #include >> @@ -226,6 +227,8 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state) >> >> trace_msm_atomic_commit_tail_start(async, crtc_mask); >> >> + drm_dp_mst_atomic_wait_for_dependencies(state); >> + >> kms->funcs->enable_commit(kms); >> >> /* >> diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c >> index 6889f1c1e72121dcc735fa460ea04cdab11c6705..09776be1d3d854f4c77d7df3afa8d56f53639411 100644 >> --- a/drivers/gpu/drm/msm/msm_kms.c >> +++ b/drivers/gpu/drm/msm/msm_kms.c >> @@ -10,6 +10,7 @@ >> #include >> #include >> >> +#include >> #include >> #include >> #include >> @@ -29,6 +30,7 @@ static const struct drm_mode_config_funcs mode_config_funcs = { >> >> static const struct drm_mode_config_helper_funcs mode_config_helper_funcs = { >> .atomic_commit_tail = msm_atomic_commit_tail, >> + .atomic_commit_setup = drm_dp_mst_atomic_setup_commit, >> }; >> >> static irqreturn_t msm_irq(int irq, void *arg) >> >> -- >> 2.34.1 >> >