From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 481CDC48BD4 for ; Tue, 25 Jun 2019 17:38:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2966E2084B for ; Tue, 25 Jun 2019 17:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732187AbfFYRiA (ORCPT ); Tue, 25 Jun 2019 13:38:00 -0400 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:55667 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729974AbfFYRh7 (ORCPT ); Tue, 25 Jun 2019 13:37:59 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 9D02718224D97; Tue, 25 Jun 2019 17:37:57 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: tent74_2823a894be11f X-Filterd-Recvd-Size: 2858 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Tue, 25 Jun 2019 17:37:55 +0000 (UTC) Message-ID: <360e2cd7578450d1a24729bf4483d0e762c21dc5.camel@perches.com> Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs From: Joe Perches To: "Gustavo A. R. Silva" , Jingoo Han , Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kees Cook , Masahiro Yamada , Michal Marek , linux-kbuild Date: Tue, 25 Jun 2019 10:37:54 -0700 In-Reply-To: <3e40f8c1-9699-2723-4e70-9e91ff256257@embeddedor.com> References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> <3e40f8c1-9699-2723-4e70-9e91ff256257@embeddedor.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-06-25 at 12:06 -0500, Gustavo A. R. Silva wrote: > > On 6/25/19 11:52 AM, Joe Perches wrote: > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > cases where we are expecting to fall through. > > [] > > > This patch is part of the ongoing efforts to enable > > > -Wimplicit-fallthrough. > > > > Just enable the thing already. > > > > If you stopped trying to do it all yourself, others > > What are you talking about? > > Anyone can enable it, I'm adding this to every commit: > > Warning level 3 was used: -Wimplicit-fallthrough=3 No one does that by default and almost no one is helping eliminate these. Not even on th Almost no one uses make W= either as it's generally extremely noisy and can emit a lot of false positives. > And I'll send a PR with a proper patch for the Makefile > during the next merge window. That's great. > If had the power I would have enabled this option since day 1, > so every developer can take care of their own code. You have always had the power to send a patch. You also seem to believe the build needs to be completely clean before enabling the switch. I don't. > Lately, you are not being of much help, Joe. What kind of help are you expecting? I'm not submitting patches adding fallthough comments as I think that's not a good form. I've said so repeatedly. I believe I suggested months ago you default enable the compiler switch. So it's up to you to either do it or not.