From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E453C64EC4 for ; Wed, 8 Mar 2023 19:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230102AbjCHTKY (ORCPT ); Wed, 8 Mar 2023 14:10:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbjCHTJ4 (ORCPT ); Wed, 8 Mar 2023 14:09:56 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE1FAF0F4 for ; Wed, 8 Mar 2023 11:09:37 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id j11so50313653edq.4 for ; Wed, 08 Mar 2023 11:09:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678302576; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KkeMJhDrlZR0CW+jwOzfg7rjixWcjZ+Lh7Jc51LTf60=; b=B96dkgosvOFrjaliQ2bHaZnATfVIl/u0wBOla4aMLgLW9v7xGKNsAkGfFhgplw/1qx 9PRA7zHf3N1TVpwuke4D1gGgHY1638Z9T+V2C3Kw2LDrlUZzrs0ABAehuNtoBHXHBE4E HeyUOgofgRQSJJyBL0AmFHfa8ywTIePc5ncbH6l2Q+drnSOaj08jk30dpNleG5AHJMI+ NfjbwhpbKbNVO4zrVwktv+RSP1Rbx3nSSh1N+TsBtdGqi8VWcJZQe6x/n+b/wk4rXXBg NnF2fG7Un4CHiSilqpPlb82PHWhwybO6LviZEcqwmZXSwJ9b3Ms8elEBgzVUuYJqx4nO Ev2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678302576; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KkeMJhDrlZR0CW+jwOzfg7rjixWcjZ+Lh7Jc51LTf60=; b=oncW5DI93U+/aQziIO4WCdM2yHjami8MPaqanNDWFyG6VTfLj20spju/oYAre3nMjw ozbcqmXibsP/h1w+7uFPrflaO/Y63aenVvzZHBbt3TOK2vOHJWlDn91y1fKlRiHWLzHb M/YfNW8WNCwBfKL6pvW7+lbHL7tJ4PCnN+vx0TPcJtZbAQ8t95SU7jJcs80gIa76NC3z grjIw+4LwF3sl8nZyx6wcMTjOCcm7V7c5snoWodKr6u6QpmYA0keAX9k54TeiiEBpxxi 3KCIoxSlAONDjW5faBfEv+/y1CpxsVYV5IfY1WlcB2rYzm48PXz9sNoNcjrG6kCAaF6l ug6w== X-Gm-Message-State: AO0yUKWB/KDrf+hb/e+Cu5goVpMrJPN0eUx1AGEtkF+8ZZD9KVyKgEjC IaNXce/7jOA+pP37I8BTej6sag== X-Google-Smtp-Source: AK7set+R6sbw18cgLNiAvl5saG3Boseyg7OJmQeoP4FW1+FdDJOmHm71GRSBxtg+nuJlzIzOZwY6oA== X-Received: by 2002:a17:906:da82:b0:88f:9f5e:f40 with SMTP id xh2-20020a170906da8200b0088f9f5e0f40mr27784941ejb.68.1678302576476; Wed, 08 Mar 2023 11:09:36 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id g10-20020a50d0ca000000b004bc9d44478fsm8601884edf.51.2023.03.08.11.09.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 11:09:36 -0800 (PST) Message-ID: <36169a8a-d418-6d7e-b64c-a7c346b9a218@linaro.org> Date: Wed, 8 Mar 2023 20:09:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [net-next PATCH 09/11] dt-bindings: net: dsa: qca8k: add LEDs definition example Content-Language: en-US To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones , linux-leds@vger.kernel.org References: <20230307170046.28917-1-ansuelsmth@gmail.com> <20230307170046.28917-10-ansuelsmth@gmail.com> <5992cb0a-50a0-a19c-3ad1-03dd347a630b@linaro.org> <6408dbbb.1c0a0220.a28ce.1b32@mx.google.com> From: Krzysztof Kozlowski In-Reply-To: <6408dbbb.1c0a0220.a28ce.1b32@mx.google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2023 20:02, Christian Marangi wrote: > On Wed, Mar 08, 2023 at 07:49:26PM +0100, Krzysztof Kozlowski wrote: >> On 08/03/2023 14:57, Andrew Lunn wrote: >>> On Wed, Mar 08, 2023 at 11:58:33AM +0100, Krzysztof Kozlowski wrote: >>>> On 07/03/2023 18:00, Christian Marangi wrote: >>>>> Add LEDs definition example for qca8k Switch Family to describe how they >>>>> should be defined for a correct usage. >>>>> >>>>> Signed-off-by: Christian Marangi >>>> >>>> Where is the changelog? This was v8 already! What happened with all >>>> review, changes? >>> >>> Did you read patch 0? >>> >>> We have decided to start again, starting small and working up. This >>> patchset just adds plain, boring LEDs. No acceleration, on hardware >>> offload. Just on/off, and fixed blink. >> >> Sure, but the patch is carried over. So what happened with all its >> feedback? Was there or was not? How can we know? >> > > The history of the old series is a bit sad, not enough review, another > dev asking for a different implementation and me doing an hybrid to > reach a common point (and then disappear intro oblivion)... > > Short story is that this current series have nothing related to the HW > offload feature and only in v7 it was asked to put the LED nodes in > ethernet-phy.yaml > > I can put in the cover letter of v2 of this series the changelog of the > previous series but they would only be related to other part that are > not related to this. > > Just to give you some context and explain why the changelog was dropped. I am less interested in the changelog of entire patchset but of the patches which are for me to review. Sending vX as v1 suggests that all previous review work on this patch could be in some limbo state. Maybe nothing happened in all previous version, but it's now my task to dig it? This is why you have "---" for the patch changelog. Best regards, Krzysztof