mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v1 1/1] serial: core: Restore sysfs fwnode information
Date: Mon, 22 Dec 2025 11:55:26 +0100	[thread overview]
Message-ID: <361ad06d-0478-40f9-9894-6f53d7b27eff@samsung.com> (raw)
In-Reply-To: <713aa37f-161d-4f08-9417-d7d2abdcdfd9@sirena.org.uk>

On 18.12.2025 17:54, Mark Brown wrote:
> On Thu, Dec 18, 2025 at 04:29:55PM +0100, Marek Szyprowski wrote:
>> On 27.11.2025 17:36, Andy Shevchenko wrote:
>>> The change that restores sysfs fwnode information does it only for OF cases.
>>> Update the fix to cover all possible types of fwnodes.
>> This patch landed in today's linux-next as commit 24ec03cc5512 ("serial:
>> core: Restore sysfs fwnode information"). In my tests I found that it
>> breaks booting of most of my test boards (ARM 32 and 64 bit).
>> Unfortunately I cannot provide anything useful besides the information
>> that booting stops and system doesn't reach shell. There is nothing
>> suspicious in the kernel logs. I suspect a memory trashing. Reverting
>> $subject on top of linux-next fixes booting.
> I'm also seeing this in my lab and Arm's lab, there are a few systems
> that survive but it's a small minority.

I have a few spare minutes and spent them analyzing this issue.

This is somehow related to dev->of_node_reused device property and its 
check in pinctrl_bind_pins() in drivers/base/pinctrl.c.

The following hack/workaround fixes the observed boot issues:

diff --git a/drivers/tty/serial/serial_base_bus.c 
b/drivers/tty/serial/serial_base_bus.c
index 8e891984cdc0..f3332a5e134c 100644
--- a/drivers/tty/serial/serial_base_bus.c
+++ b/drivers/tty/serial/serial_base_bus.c
@@ -76,6 +76,7 @@ static int serial_base_device_init(struct uart_port *port,
         dev->release = release;

         device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev)));
+       dev->of_node_reused = true;

         if (!serial_base_initialized) {
                 dev_dbg(port->dev, "uart_add_one_port() called before 
arch_initcall()?\n");


If I then remove the dev->of_node_reused check in pinctrl_bind_pins(), 
the affected boards don't boot again the same way. I hope this helps 
fixing this issue.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  reply	other threads:[~2025-12-22 11:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 16:36 Andy Shevchenko
2025-11-27 19:07 ` Greg Kroah-Hartman
2025-12-18 13:50 ` Cosmin Tanislav
     [not found] ` <CGME20251218152957eucas1p196470bc80be0d8a4037edfe6e53f3d13@eucas1p1.samsung.com>
2025-12-18 15:29   ` Marek Szyprowski
2025-12-18 16:54     ` Mark Brown
2025-12-22 10:55       ` Marek Szyprowski [this message]
2025-12-29  3:18         ` Dmitry Baryshkov
2025-12-29 12:38           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=361ad06d-0478-40f9-9894-6f53d7b27eff@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®