From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC7F1DFD98 for ; Thu, 5 Dec 2024 13:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733407094; cv=none; b=j3GgFVu7GBbimlPk4wECnfQIq71EHF+hCDwJ6mJnn3AxsCRVTfZckILc8JPmMXaM37ORx77gb0Fzba6QV7HZ18Dlcgej/967qRdCe10Q4KFKz8vpdPmMCCu3CV/5knPmJb5J9zDsXYQwX/SHvSyOBVyp4kUl60ubzk3ZtUGLueI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733407094; c=relaxed/simple; bh=Whztqzqhd31DO6J1pWBJGbIcubmLvvZmURKz55fjQck=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HXGNQCZK/iv3xTncY74Id7Q9JreJXADZmpPRYwvtLyNkCqRKuGM0+F0tYSMghAa17K+8t3gKh2RSj2c5YPDV2jNx4WwXegSAFxqDmpkNbETKVsqRafvRh3QLwSk7MAe8aFlFtggLooVv+uCriOtpy+/mFC8FySMMVU8bVpGOxHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tJCMh-0000kQ-S9; Thu, 05 Dec 2024 14:57:59 +0100 Message-ID: <361b3a14-db86-4c3c-9f07-4ebc1dd40d0e@pengutronix.de> Date: Thu, 5 Dec 2024 14:57:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] arm: dts: st: stm32mp151a-prtt1l: Fix QSPI configuration To: Alexandre TORGUE , Oleksij Rempel , Maxime Coquelin , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20240806120517.406714-1-o.rempel@pengutronix.de> <20dc2cd4-7684-4894-9db3-23c3f4abd661@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hello Alex, On 29.10.24 16:39, Alexandre TORGUE wrote: > On 8/7/24 11:38, Ahmad Fatoum wrote: >> Hello Oleksij, >> >> On 06.08.24 14:05, Oleksij Rempel wrote: >> There's bias-disable in stm32mp15-pinctrl.dtsi. You may want to add >> a /delete-property/ for that to make sure, it's not up to the driver >> which one has priority. >> >>>           drive-push-pull; >>>           slew-rate = <1>; >> >> These are already in qspi_bk1_pins_a. If repeating those is ok, why >> not go a step further and just duplicate the pinmux property and stay >> clear of this issue altogether, provided Alex is amenable to changing >> his mind regarding pinctrl groups in board device trees. > > I still prefer to have pin configuration defined in pinctrl dtsi file and I'll continue like this for ST board. The reason is that we try to reuse as much as possible pins when we create a new board and so it is easier to maintain if we declare them only one time. I can see the point for ST evaluation kits as ST customer hardware will often copy the reference designs. > But, I'm not blocked for "other" boards based on STM32 SoC. I mean, if it is simpler for you and above all if it avoid issues/complexities then, you can declare some pin groups in your board dts file. In this case we need to take care of the IO groups label name. That's good to hear and what I wanted to clarify. Especially for things like ADCs, there are so many possible permutations that there is no point for boards to add their pinctrl group to the main DTSI instead of just listing their specific pin configuration in the board DTS. Thanks, Ahmad > > regards > alex > >> >> >> Cheers, >> Ahmad >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |