From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA633EDAC7 for ; Thu, 9 Jul 2026 11:14:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595689; cv=pass; b=HOcPFSvxkcXJ+GbaASaUr6+nb6U7SZNnvffSl3+q48aTtFhfqiVlkYt7UCP0LYOCQ3YoeL4BxuViKvqD5jBNr01N2wgukG+slwhYlnSM9bG8Myvq2zOxA2xXoPeBAorcs2dqYEccHMx1vsNfpC9eQ9uqVrMSIJr9fqgmllgm530= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783595689; c=relaxed/simple; bh=BqJjgexZU0mY8BmQn07VBjFUPQyN1xK+t7xcSFeeQgs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SfxInCUfrtN2SFzbq/adMXdBVN9QMbLS3kSw4hiiqFwlHt47yw2dS6fpUYDygYOfwbzCiuLaPjXmXvAb8rI+citRuFwUThefbXXphnFlf1O7+j3YBdVSYTYl3mDL37M/7KtBJe+6uy/hnvZNTT1jq9Y25PfB+wpZRLsyMp4o9Rg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=robert.mader@collabora.com header.b=NUb4xyuv; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=robert.mader@collabora.com header.b="NUb4xyuv" ARC-Seal: i=1; a=rsa-sha256; t=1783595660; cv=none; d=zohomail.com; s=zohoarc; b=KNcqOPV908wS/IFidXvtJ3W/tTwK9fEQk92s28HHlHQyVPJ8vDqnkBYevag7hL2mCUbN0HeSoxqCrlc6AWQlXlhACfmcnuTWJfcIYps42HGmGt/KSbihAj77Yq3JIQvSF9BGEMeCh7ERj84qPNZJmZShpWNX+F15hqH4BW3xfxI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783595660; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=9aocsOpowH+ZsBOhN77TCgYYBcPmRbX7RXXs+joV1Gw=; b=VL4p18jXQIzw3KeXR9ZUuUT0xbLzz3Jzubs4+7S6g87rQlwsToXdMhcsDqcBjlqWdA40HlyKcWidbnABbv26knP8fCgVs3T/2u+D62reMEKr31OBQZPE+B/SepqJ92KkC8DcWpCr2J3EFfO8aOxI2pZDAWyO5NH74sPjJCoF1ns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783595660; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=9aocsOpowH+ZsBOhN77TCgYYBcPmRbX7RXXs+joV1Gw=; b=NUb4xyuvRJ1x3cCc1/J0Uv8Lv2bWQwyPXIoYviH9KlZCnqxVnp9Q75FkV5AV+gvZ AS9mlmIcSujlIhxzOVdiydiDrN2DRRd7ZvuGpAnpMmJ5eW9mDcFgQzDnCltNZ8WsAMi fkmG998SA/g41RNWDZuRPchLWCdqI3aUO1qArUZs= Received: by mx.zohomail.com with SMTPS id 17835956579351020.4396036820058; Thu, 9 Jul 2026 04:14:17 -0700 (PDT) Message-ID: <361dfc91-94e8-4289-9b3e-5280803d9257@collabora.com> Date: Thu, 9 Jul 2026 13:14:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] drm: Guard DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE To: Maarten Lankhorst , "Borah, Chaitanya Kumar" , dri-devel@lists.freedesktop.org Cc: Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Harry Wentland , Daniel Stone , Uma Shankar , Louis Chauvet , Melissa Wen , Simon Ser , Pekka Paalanen , Leandro Ribeiro References: <20260703073230.19982-1-robert.mader@collabora.com> <6d8806b8-fc71-4699-82c4-7189a0ea2284@intel.com> <7d58b289-eabe-4d68-9080-c7202b0f60a0@intel.com> Content-Language: en-US, de-DE From: Robert Mader In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 09.07.26 12:02, Maarten Lankhorst wrote: > Hey, > > On 7/9/26 08:44, Borah, Chaitanya Kumar wrote: >> >> On 7/7/2026 6:31 PM, Maarten Lankhorst wrote: >>> Hey, >>> >>> On 7/7/26 10:03, Borah, Chaitanya Kumar wrote: >>>> On 7/3/2026 1:02 PM, Robert Mader wrote: >>>>> The client cap is currently advertised unconditionally, even for drivers >>>>> that do not support plane color pipelines. If clients supporting the later, >>>> s/later/latter >>>> >>>>> like Wayland compositors or tools like drm_info, enable the client cap on >>>>> such drivers they will be left without both color pipeline and the legacy >>>>> properties COLOR_ENCODING and COLOR_RANGE, effectively breaking YUV->RGB >>>>> conversion support. >>>>> >>>>> Prevent that by only marking the cap supported if there are actually planes >>>>> with color pipelines. >>>>> >>>>> Note: while the color pipeline replacement for the legacy properties is >>>>> still under review (1), we can assume that it will work as a drop-in >>>>> replacement. >>>> This change will but a driver can also choose to export colorops like programmable CTM_3x4 to achieve the same. >>>> >>>> We should also perhaps document this somewhere that if a driver supports LEGACY properties, it is imperative to implement some version of it with the color pipeline line property. >>> Would this be doable inside drm core? Implement the color pipeline properties, get the fixed pipeline for free? >> Right now, the Bypass(default) pipeline is automatically created when we call drm_plane_create_color_pipeline_property(), we could come up with a similar helper that could also create a pipeline that replaces the legacy properties. >> >> But this can't replace the existing helper entirely because some HW (though unlikely) might not support YUV buffers. > No need to do this for free, but a cheaper way for drivers to implement legacy > properties by only implementing the pipeline would be nice, similar to how > atomic also implements legacy modesetting and universal planes. I really like this idea - should we take it to the corresponding series, https://lore.kernel.org/dri-devel/20260623164812.81110-1-harry.wentland@amd.com/ so the initial implementations for AMD and VKMS directly do so? Regards > > Kind regards, > ~Maarten Lankhorst -- Robert Mader Consultant Software Developer Collabora Ltd. Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK Registered in England & Wales, no. 5513718