From: David Hildenbrand <david@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, Pankaj Gupta <pagupta@redhat.com>
Cc: kwolf@redhat.com, haozhong zhang <haozhong.zhang@intel.com>,
jack@suse.cz, xiaoguangrong eric <xiaoguangrong.eric@gmail.com>,
kvm@vger.kernel.org, riel@surriel.com, linux-nvdimm@ml01.01.org,
mst@redhat.com, ross zwisler <ross.zwisler@intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
hch@infradead.org, pbonzini@redhat.com, stefanha@redhat.com,
niteshnarayanlal@hotmail.com, marcel@redhat.com,
imammedo@redhat.com, dan j williams <dan.j.williams@intel.com>,
nilal@redhat.com
Subject: Re: [Qemu-devel] [RFC] qemu: Add virtio pmem device
Date: Mon, 9 Apr 2018 08:42:35 +0200 [thread overview]
Message-ID: <36218ea8-5fa8-e670-104d-616da790a333@redhat.com> (raw)
In-Reply-To: <20180409032601.GA1648@stefanha-x1.localdomain>
On 09.04.2018 05:26, Stefan Hajnoczi wrote:
> On Thu, Apr 05, 2018 at 08:09:26AM -0400, Pankaj Gupta wrote:
>>> Will this raw file already have the "disk information header" (no idea
>>> how that stuff is called) encoded? Are there any plans/possible ways to
>>>
>>> a) automatically create the headers? (if that's even possible)
>>
>> Its raw. Right now we are just supporting raw format.
>>
>> As this is direct mapping of memory into guest address space, I don't
>> think we can have an abstraction of headers for block specific features.
>> Or may be we can get opinion of others(Qemu block people) it is at all possible?
>
> memdev and the block layer are completely separate. The block layer
> isn't designed for memory-mapped access.
>
Not questioning if this is the right thing to do now. I was wondering if
we could expose any block device in the future as virtio-pmem. And I
think with quite some work it could be possible.
As you said, we will need some buffering. Maybe userfaultfd and friends
(WP) could allow to implement that.
> I think it makes sense to use memdev here. If the user wants a block
> device, they should use an emulated block device, not virtio-pmem,
> because buffering is necessary anyway when an image file format is used.
>
> Stefan
>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2018-04-09 6:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 10:48 [RFC 0/2] kvm "fake DAX" device flushing Pankaj Gupta
2018-04-05 10:48 ` [RFC 1/2] kvm: add virtio pmem driver Pankaj Gupta
2018-04-05 10:48 ` [RFC 2/2] pmem: device flush over VIRTIO Pankaj Gupta
2018-04-05 10:48 ` [RFC] qemu: Add virtio pmem device Pankaj Gupta
2018-04-05 11:26 ` David Hildenbrand
2018-04-05 12:09 ` [Qemu-devel] " Pankaj Gupta
2018-04-05 12:19 ` David Hildenbrand
2018-04-09 3:26 ` Stefan Hajnoczi
2018-04-09 6:42 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36218ea8-5fa8-e670-104d-616da790a333@redhat.com \
--to=david@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=haozhong.zhang@intel.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=niteshnarayanlal@hotmail.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=ross.zwisler@intel.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®