Re: [PATCH v4 0/7] ACPICA / debugger: Add in-kernel AML debugger support

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Thursday, December 03, 2015 10:40:00 AM Lv Zheng wrote:
> This patchset enables ACPICA debugger for Linux kernel and implements a
> userspace utility to access it.
> 
> A. Build the AML debugger
> In order to build the kernel support of AML debugger, the following kconfig
> items should be enabled:
>  CONFIG_ACPI_DEBUG=y
>  CONFIG_ACPI_DEBUGGER=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_ACPI_DEBUGGER_USER=m
> The userspace tool can be found at tools/power/acpi/tools/acpidbg. To
> build this utility, staying in tools folder and type "make acpi".
> 
> B. Load the AML debugger during runtime
> In order to use the in-kernel AML debugger, the following command should be
> executed using root user:
>  # modprobe acpi_dbg
>  # mount -t debugfs none /sys/kernel/debug
>  # acpidbg
> 
> C. Batch mode
> In order to support scripts, the userspace utility also supports single
> command batch mode:
>  # acpidbg -b "help"
>  # acpidbg -b "tables"
>  # acpidbg -b "find _LID"
>  # acpidbg -b "execute \_SB.LID0._LID"
> You can find the documentation about the ACPICA debugger commands in:
>  https://acpica.org/sites/acpica/files/acpica-reference_17.pdf
>  (The latest document can be found at https://acpica.org/documentation)
> And refer to the chapter - ACPICA debugger reference to obtain the full
> description of the debugger commands. Note that not all commands are
> supported by an in-kernel AML debugger.
> 
> D. Unload the AML debugger during runtime
> After terminating all acpidbg instances, the following command can be
> executed to remove the AML debugger from kernel:
>  # rmmod acpi_dbg
> 
> The following tasks are not completed:
> 1. .flush() support in the kernel debugger IO driver.
> 2. multi-commands batch mode.
> 
> v2:
> 1. Fix a help message issue for the userspace acpidbg utility (this is a
>    typo fix).
> 2. Fix a batch mode issue by adding "\n" to the prompt sequence (this was
>    lost due to too many rebase cycles).
> 3. Fix kconfig dependency for an intermediate patch (this is only useful in
>    case the latter patches are reverted).
> 4. Add more accurate runtime debugger stub mechanism and remove old
>    ACPI_DEBUGGER_EXEC() stub mechanism.
> 5. Add x86 acpi_os_readable() support.
> 
> v3:
> 1. Remove acpi_os_readable() support from this patchset. It's sent separately.
> 2. Delete some deprecated comments.
> 
> v4:
> 1. Rebase patch 4/6 because of Kconfig changes.
> 2. Include acpi_os_readable() back as no objections, also test result is
>    positive.
> 
> Chen Yu (1):
>   ACPI / x86: introduce acpi_os_readable() support
> 
> Colin Ian King (1):
>   ACPICA: Debugger: Remove unnecessary status check
> 
> Lv Zheng (5):
>   ACPICA: Debugger: Convert some mechanisms to OSPM specific
>   ACPICA: Debugger: Fix runtime stub issues of ACPI_DEBUGGER_EXEC using
>     different stub mechanism
>   ACPI / debugger: Add IO interface to access debugger functionalities
>   tools/power/acpi: Add userspace AML interface support
>   ACPI / debugger: Add module support for ACPI debugger

OK, I'm queuing up [1-6/7] for 4.5.

The [7/7] needs at least to be looked at by the x86 maintainers.

Thanks,
Rafael