From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1983DC71153 for ; Wed, 30 Aug 2023 02:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241792AbjH3C4K (ORCPT ); Tue, 29 Aug 2023 22:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241790AbjH3Cz6 (ORCPT ); Tue, 29 Aug 2023 22:55:58 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 807C91BD for ; Tue, 29 Aug 2023 19:55:55 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91A742F4; Tue, 29 Aug 2023 19:56:34 -0700 (PDT) Received: from [10.163.58.191] (unknown [10.163.58.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EF5CA3F740; Tue, 29 Aug 2023 19:55:47 -0700 (PDT) Message-ID: <3622f8fe-00c4-298e-0b35-06bb61b92cde@arm.com> Date: Wed, 30 Aug 2023 08:25:45 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/mmap: Define DEFAULT_STACK_GUARD_GAP To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org References: <20230828035248.678960-1-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/23 18:02, Matthew Wilcox wrote: > On Mon, Aug 28, 2023 at 09:22:48AM +0530, Anshuman Khandual wrote: >> This just defines a macro constant i.e DEFAULT_STACK_GUARD_GAP representing >> the default gap, guarding the stack mapping. This does not cause functional >> changes. > > But why have you done it at all? Just as a normal cleanup which also improves readability.