From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756229AbdETTOU (ORCPT ); Sat, 20 May 2017 15:14:20 -0400 Received: from mout.web.de ([212.227.17.11]:63359 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbdETTOR (ORCPT ); Sat, 20 May 2017 15:14:17 -0400 Subject: [PATCH 3/5] fsl_hypervisor: Return the success indication only as a constant in fsl_hv_open() From: SF Markus Elfring To: Arnd Bergmann , Jan Kara , Jesper Nilsson , Kumar Gala , Lorenzo Stoakes , Michal Hocko , Timur Tabi Cc: LKML , kernel-janitors@vger.kernel.org References: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Message-ID: <36267d50-b81b-be17-5050-221d5a560eca@users.sourceforge.net> Date: Sat, 20 May 2017 21:13:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <38a9b933-4cdc-53e7-0a4c-20f96c57648c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:hTNujxSK/u5Wf4TL1omx75CTW/KG8rDV4HYqYCPXR5SM5j0Z7jQ DkBwMrSnypHzqMP/19foAkjUkZZ62BnphyOBXs3PIyNNrcq06Lel2Izft0aBY+o19s/6ZsR 73sFBxr+mQXO7RpxkhtB2IKQ4zxh9X1J8Nhta7fZJSXy7UXlS4mGLjUCS11lOqpUT3125Kd 2TbQlhAU4kynz6sXUDBGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ivgx0nCerRU=:XIKzE+3UoScB1oYHH0WAMh hUInjmgDgQZKIMdq7Lb6HjM7PMSYiYRxHJvzEUao7gJLjQa2qdPDh5mYy1AO6ijvlTo6Xj+Fi UTT7kb9IPRzKV/4eMqlNP5KPCLJLi7trlwYcNhULVzoenerzLoL60C8d4QU2xKysW098BEJif qbP/z4rQWy8C5evG5bgHewSjtRS1/knI5F204h80ZoeFiOd9RtlEudESwY9Y+lulK2+bDHv8O pgifTYaGqmKRkuq0kdA+elbgLamuS3Op+PBM4Oa7SGNphlHF83k+f4HMBWoRwU5WXScqFi8a5 sZnBno6rYO9A282zpuxY60CopTaVIvbmrfOASxcpLdeLoDPrIDMa9eM1HsR28MwUlZpZxJF5P 8LAGGKwLEU9wje9p5Spz6jOjsBey9RMlz2sD456V5qP4Y4Hfa+svjrAVfEZfWbVtIWnhR+54Z Cud+/pODo4kYSTUVTE832aDaOHN25xDWNE1ImHHCKTeFh+gsZvKdQ68GAyS9id+/N8gydxQFR ewNj5YnmLrE9QvYJikwY9qwKLWfTl1mN5H4JlWZSuwdhaG3E8hkinMQS4ftKN5DKAGIUwv1NX 6S+bcqAWY7QbZQe1LSiYCrVLyArP/r/GeoWtUsff6WtfGKGEUv8p3Jis1QZY+LZLLSTWMNO5Y ZQ904maeDbbjZMR7cVQrZFlmyzXpTHuqCGCwaCBdBFREtFwOuVuIzfdw1em8uVYRfk9Y/kt82 zs0ETi9pOYhauRWDioJi5WyusnddzZd5cKs1AFrJbfKf4F8yXvezaMXHZuzSsbSPkVVshKXhR 6JtjWU8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 20:05:19 +0200 * Return a success code without storing it in an intermediate variable. * Delete the local variable "ret" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/virt/fsl_hypervisor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c index 40c5eb64f39b..9e881dc29c6b 100644 --- a/drivers/virt/fsl_hypervisor.c +++ b/drivers/virt/fsl_hypervisor.c @@ -657,7 +657,6 @@ static int fsl_hv_open(struct inode *inode, struct file *filp) { struct doorbell_queue *dbq; unsigned long flags; - int ret = 0; dbq = kzalloc(sizeof(*dbq), GFP_KERNEL); if (!dbq) @@ -671,8 +670,7 @@ static int fsl_hv_open(struct inode *inode, struct file *filp) spin_unlock_irqrestore(&db_list_lock, flags); filp->private_data = dbq; - - return ret; + return 0; } /* -- 2.13.0