From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763E2C433E0 for ; Mon, 27 Jul 2020 15:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D6882064B for ; Mon, 27 Jul 2020 15:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="VtzMBn4c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729845AbgG0PFS (ORCPT ); Mon, 27 Jul 2020 11:05:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728933AbgG0PFR (ORCPT ); Mon, 27 Jul 2020 11:05:17 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CE89C0619D2 for ; Mon, 27 Jul 2020 08:05:17 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id f9so3437884pju.4 for ; Mon, 27 Jul 2020 08:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=07ri+IqTYf1fjZepY5g8VXcoLFcfPO4oBtO7lv1kJDA=; b=VtzMBn4crNcZcyJ+6o1zOaOYWkPDW13gNgR/hm+I0N4aKLfjebBb5nppjE45zA9dyp +hyrV6pvrdgbf97Wkl1Q6psPTU36m4VY8yLOyRo7gWqFg97E5LwNc4F+l88xkgh1agc1 bp120hrWMZKD5/wKlHzhmGOTHXm1pKhrKsBYKmC9liWVrb/UYCT1L3HsYfq3FzFm0mQP 4kHW3zAxF/IH1Dtj8WbC3R301ww9Q5uJ8AhuLwZ5sMzxunEVz7upcJ6AFeiBYYqGGhvn Bo0USFHWfmdjdxhyVBgIQLyKf75toRwq/L9nZNsDKTgQCDVI21xrIav4V499iP3HxZzB rr7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=07ri+IqTYf1fjZepY5g8VXcoLFcfPO4oBtO7lv1kJDA=; b=p+JZX+SpKa6vqQos9VipfcCzvqi5ZRzX4fA7fhABrHAyk33nMYl3EWJJrWyY+Kg+US 0EEaCLTN3FIc57qfHcotwgmbv2/uztku3y6xOkr8CVrcZ1eGH9w7DWGoaWbvPmf/DMjw dEd4hJhWks7OQuq3mq0PXGCv+I+Pf+jO4QiTQfm6WC4c2azePGGY/9PSlTqZ40xodU0d EROuVSF6YZ/w/IHC2hxmHhX0M56hp+w154kidAACSck+RMmvyD4a/ymDRRf4jZ74qTdC 6NM4l4EChPSPPW4T11pVNxZQGYoXKMqpigyN3IH0aPM5iyWicLUZ2VgC6B71/ecjKsx9 Srfw== X-Gm-Message-State: AOAM532ERAHuyadvAnWYKGyAYI/jU8wPaGZp9ebB/JdQOYwKobIdZ195 foOecTDvyqcvRur0SKELLDk5nA== X-Google-Smtp-Source: ABdhPJzl+1AJvlc0PN8W87qhHbl+tCsEGCMPA6OLS0Jj0M0Mch+md2d5VMA8Qx8nv/ct38VCt1mdZQ== X-Received: by 2002:a17:90a:6888:: with SMTP id a8mr18507355pjd.59.1595862316701; Mon, 27 Jul 2020 08:05:16 -0700 (PDT) Received: from [192.168.1.102] (c-24-20-148-49.hsd1.or.comcast.net. [24.20.148.49]) by smtp.gmail.com with ESMTPSA id 22sm15115563pfh.157.2020.07.27.08.05.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2020 08:05:15 -0700 (PDT) From: "Sean V Kelley" To: "Jonathan Cameron" Cc: bhelgaas@google.com, rjw@rjwysocki.net, tony.luck@intel.com, "Raj, Ashok" , sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Qiuxu Zhuo" Subject: Re: [RFC PATCH 2/9] PCI: Extend Root Port Driver to support RCEC Date: Mon, 27 Jul 2020 08:05:16 -0700 X-Mailer: MailMate (1.13.1r5671) Message-ID: <3628B87C-DE0E-477E-85C1-FFD154DC4EFD@intel.com> In-Reply-To: <20200727133010.00003de8@Huawei.com> References: <20200724172223.145608-1-sean.v.kelley@intel.com> <20200724172223.145608-3-sean.v.kelley@intel.com> <20200727133010.00003de8@Huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 Jul 2020, at 5:30, Jonathan Cameron wrote: > On Fri, 24 Jul 2020 10:22:16 -0700 > Sean V Kelley wrote: > >> From: Qiuxu Zhuo >> >> If a Root Complex Integrated Endpoint (RCiEP) is implemented, errors = >> may >> optionally be sent to a corresponding Root Complex Event Collector = >> (RCEC). >> Each RCiEP must be associated with no more than one RCEC. Interface = >> errors >> are reported to the OS by RCECs. >> >> For an RCEC (technically not a Bridge), error messages "received" = >> from >> associated RCiEPs must be enabled for "transmission" in order to = >> cause a >> System Error via the Root Control register or (when the Advanced = >> Error >> Reporting Capability is present) reporting via the Root Error Command >> register and logging in the Root Error Status register and Error = >> Source >> Identification register. >> >> Given the commonality with Root Ports and the need to also support = >> AER >> and PME services for RCECs, extend the Root Port driver to support = >> RCEC >> devices through the addition of the RCEC Class ID to the driver >> structure. >> > Hi. > > I'm surprised it ended up this simple :) Seems we are a bit lucky that > the existing code is rather flexible on what is there and what isn't > and that there is never any reason to directly touch the various > type1 specific registers (given as I read the spec, an RCEC uses a > type0 config space header unlike the ports). Which is part of the reason why I chose to refer to it as an RFC, = because it seemed simpler and I was unsure if we were missing anything, = and it turns out we were. Unfortunately, to avoid churn, I=E2=80=99ve lef= t = quite a bit of comments/naming intact with =E2=80=9Croot=E2=80=9D/=E2=80=9C= port=E2=80=9D terms. > > Given you mention PME, it's probably worth noting (I think) you aren't > actually enabling the service yet as there is a check in that path on = > whether we > have a root port or not. > https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/pci/pcie/portd= rv_core.c#L241 Good catch, testing has been only done at this point with AER injection. Will correct. Thanks, Sean > > Thanks, > > Jonathan > > >> Co-developed-by: Sean V Kelley >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Sean V Kelley >> --- >> drivers/pci/pcie/portdrv_pci.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pci/pcie/portdrv_pci.c = >> b/drivers/pci/pcie/portdrv_pci.c >> index 3acf151ae015..d5b109499b10 100644 >> --- a/drivers/pci/pcie/portdrv_pci.c >> +++ b/drivers/pci/pcie/portdrv_pci.c >> @@ -106,7 +106,8 @@ static int pcie_portdrv_probe(struct pci_dev = >> *dev, >> if (!pci_is_pcie(dev) || >> ((pci_pcie_type(dev) !=3D PCI_EXP_TYPE_ROOT_PORT) && >> (pci_pcie_type(dev) !=3D PCI_EXP_TYPE_UPSTREAM) && >> - (pci_pcie_type(dev) !=3D PCI_EXP_TYPE_DOWNSTREAM))) >> + (pci_pcie_type(dev) !=3D PCI_EXP_TYPE_DOWNSTREAM) && >> + (pci_pcie_type(dev) !=3D PCI_EXP_TYPE_RC_EC))) >> return -ENODEV; >> >> status =3D pcie_port_device_register(dev); >> @@ -195,6 +196,8 @@ static const struct pci_device_id port_pci_ids[] = >> =3D { >> { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x00), ~0) }, >> /* subtractive decode PCI-to-PCI bridge, class type is 060401h */ >> { PCI_DEVICE_CLASS(((PCI_CLASS_BRIDGE_PCI << 8) | 0x01), ~0) }, >> + /* handle any Root Complex Event Collector */ >> + { PCI_DEVICE_CLASS(((PCI_CLASS_SYSTEM_RCEC << 8) | 0x00), ~0) }, >> { }, >> }; >>