From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B60C77B6C for ; Thu, 6 Apr 2023 09:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234663AbjDFJNc (ORCPT ); Thu, 6 Apr 2023 05:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbjDFJN2 (ORCPT ); Thu, 6 Apr 2023 05:13:28 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595C24EED for ; Thu, 6 Apr 2023 02:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680772347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sv2PpChimMYumCFtZaOaAxih1ECUzoRlTNbMO8Dqb/8=; b=Jkwyc4Lq67oa21YjMIPX/DUU6w/tJ4GvV7lGelU5IuqR2GuM4SzO8rfoQqNEcU5JshFyrv T7pbyOMo4yuK20i8FfnmU/R0nFVV8F83btHC+9EybH2hj6sSCfoH9jjRUiTJq02xXUDlfI VY2zoeOF2ywf/qHJGl+7cigF8OtoeMg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-bbJHhxB2MTulRR-9lYLWOw-1; Thu, 06 Apr 2023 05:12:22 -0400 X-MC-Unique: bbJHhxB2MTulRR-9lYLWOw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FBCA38123B9; Thu, 6 Apr 2023 09:12:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84D22492C14; Thu, 6 Apr 2023 09:12:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230405191915.041c2834@kernel.org> References: <20230405191915.041c2834@kernel.org> <20230405165339.3468808-1-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v4 00/20] splice, net: Replace sendpage with sendmsg(MSG_SPLICE_PAGES), part 1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3629143.1680772339.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 06 Apr 2023 10:12:19 +0100 Message-ID: <3629144.1680772339@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski wrote: > Thanks for splitting off a smaller series! > My day is out of hours so just a trivial comment, in case kbuild bot > hasn't pinged you - this appears to break the build on the relatively > recently added page_frag_cache in google's vNIC (gve). Yep. I've just been fixing that up. I'll also break off the samples patch and that can go by itself. Is there= a problem with the 32-bit userspace build environment that patchwork is usin= g? The sample programs that patch adds are all userspace helpers. It seems t= hat is referencing a file that doesn't exist: In file included from /usr/include/features.h:514, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdio.h:27, from ../samples/net/alg-hash.c:9: /usr/include/gnu/stubs.h:7:11: fatal error: gnu/stubs-32.h: No such file o= r directory 7 | # include | ^~~~~~~~~~~~~~~~ compilation terminated. Excerpt from: https://patchwork.hopto.org/static/nipa/737278/13202278/build_32bit/ https://patchwork.kernel.org/project/netdevbpf/patch/20230405165339.346880= 8-2-dhowells@redhat.com/ David