From: Colin Ian King <colin.king@canonical.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] spi: loopback-test: make several module parameters static
Date: Tue, 18 Jul 2017 14:13:35 +0100 [thread overview]
Message-ID: <362dce57-c28b-3258-7411-1c0724545c3f@canonical.com> (raw)
In-Reply-To: <20170718130939.5knxusi4d6e32wh4@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 488 bytes --]
On 18/07/17 14:09, Mark Brown wrote:
> On Tue, Jul 18, 2017 at 01:42:32PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>
> It would be very helpful if you could ensure your commit author and
> e-mail From: line up so that git doesn't make your patches look like
> non-author signoffs.
>
> The [next] isn't needed in the subject line either, it just makes more
> of the subject line get hidden.
>
ACK, will do. Want me to resend this patch?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 837 bytes --]
next prev parent reply other threads:[~2017-07-18 13:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 12:42 Colin King
2017-07-18 13:09 ` Mark Brown
2017-07-18 13:13 ` Colin Ian King [this message]
2017-07-18 13:27 ` Mark Brown
2017-07-18 13:49 ` Applied "spi: loopback-test: make several module parameters static" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=362dce57-c28b-3258-7411-1c0724545c3f@canonical.com \
--to=colin.king@canonical.com \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®