From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686AbcHZJTu convert rfc822-to-8bit (ORCPT ); Fri, 26 Aug 2016 05:19:50 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15506 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbcHZJTr (ORCPT ); Fri, 26 Aug 2016 05:19:47 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 26 Aug 2016 02:15:34 -0700 From: Shardar Mohammed To: Wolfram Sang CC: Laxman Dewangan , "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" , "gnurou@gmail.com" , "linux-i2c@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Thread-Topic: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Thread-Index: AQHR/wh54vIsUpwtFkyoIHkIz2UWT6Ba967w Date: Fri, 26 Aug 2016 09:19:40 +0000 Message-ID: <362fc8af7f8d411c8af36b34c6165c1b@bgmail102.nvidia.com> References: <1464356224-10339-1-git-send-email-smohammed@nvidia.com> <20160619172136.GE2933@tetsubishi> <6d21b4bd199844e3a359cc52823045db@bgmail102.nvidia.com> <20160825193952.GC1614@katana> In-Reply-To: <20160825193952.GC1614@katana> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.24.71.9] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: Friday, August 26, 2016 1:10 AM > To: Shardar Mohammed > Cc: Laxman Dewangan; swarren@wwwdotorg.org; > thierry.reding@gmail.com; gnurou@gmail.com; linux-i2c@vger.kernel.org; > linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after > config_load reg programmed > > * PGP Signed by an unknown key > > > > > > + err = readx_poll_timeout(readl, i2c_dev->base + reg_offset, > > > > + val, val == 0, 1000, > > > > + I2C_CONFIG_LOAD_TIMEOUT); > > > > > > Any reason we can't use readl_poll_timeout() here? > > [Shardar] Can be used, will change and push the new patchset. > > Still interested? Should be an easy change, but I am reluctant to fix it here > with no testing. [Shardar] Will push the change by tomorrow. > > > * Unknown Key > * 0x14A029B6