From: Dave Hansen <dave.hansen@intel.com>
To: "Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <shy828301@gmail.com>, Michal Hocko <mhocko@suse.com>,
Wei Xu <weixugc@google.com>, David Rientjes <rientjes@google.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
osalvador <osalvador@suse.de>
Subject: Re: [PATCH -V8 02/10] mm/numa: automatically generate node migration order
Date: Mon, 21 Jun 2021 12:53:04 -0700 [thread overview]
Message-ID: <36307d7a-6e39-b1dd-64e8-95ec59f16867@intel.com> (raw)
In-Reply-To: <87v96anu6o.fsf@yhuang6-desk2.ccr.corp.intel.com>
On 6/19/21 1:18 AM, Huang, Ying wrote:
>>> int next_demotion_node(int node)
>>> {
>>> - return node_demotion[node];
>>> + /*
>>> + * node_demotion[] is updated without excluding
>>> + * this function from running. READ_ONCE() avoids
>>> + * reading multiple, inconsistent 'node' values
>>> + * during an update.
>>> + */
>>> + return READ_ONCE(node_demotion[node]);
>>> }
>> Is it necessary to have two separate patches to add node_demotion and
>> next_demotion_node() then modify it immediately? Maybe merge Patch 1 into 2?
>>
>> Hmm, I just checked Patch 3 and it changes node_demotion again and uses RCU.
>> I guess it might be much simpler to just introduce node_demotion with RCU
>> in this patch and Patch 3 only takes care of hotplug events.
> Hi, Dave,
>
> What do you think about this?
>
Squashing them seems like a good idea to me.
next prev parent reply other threads:[~2021-06-21 19:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 6:15 [PATCH -V8 00/10] Migrate Pages in lieu of discard Huang Ying
2021-06-18 6:15 ` [PATCH -V8 01/10] mm/numa: node demotion data structure and lookup Huang Ying
2021-06-18 6:15 ` [PATCH -V8 02/10] mm/numa: automatically generate node migration order Huang Ying
2021-06-18 15:14 ` Zi Yan
2021-06-19 8:18 ` Huang, Ying
2021-06-21 19:51 ` Yang Shi
2021-06-22 0:55 ` Huang, Ying
2021-06-21 19:53 ` Dave Hansen [this message]
2021-06-22 0:54 ` Huang, Ying
[not found] ` <2AA3D792-7F14-4297-8EDD-3B5A7B31AECA@nvidia.com>
2021-06-22 1:14 ` Huang, Ying
2021-06-22 12:13 ` Dave Hansen
2021-06-22 12:06 ` Dave Hansen
2021-06-22 12:48 ` Zi Yan
2021-06-18 6:15 ` [PATCH -V8 03/10] mm/migrate: update node demotion order during on hotplug events Huang Ying
2021-06-18 6:15 ` [PATCH -V8 04/10] mm/migrate: make migrate_pages() return nr_succeeded Huang Ying
2021-06-18 7:53 ` Oscar Salvador
2021-06-18 8:15 ` Huang, Ying
2021-06-18 6:15 ` [PATCH -V8 05/10] mm/migrate: demote pages during reclaim Huang Ying
2021-06-18 15:42 ` Zi Yan
2021-06-19 7:45 ` Huang, Ying
2021-06-21 19:58 ` Yang Shi
2021-06-22 2:09 ` Huang, Ying
2021-06-22 17:15 ` Yang Shi
2021-06-22 18:15 ` Zi Yan
2021-06-23 2:19 ` Huang, Ying
2021-06-18 6:15 ` [PATCH -V8 06/10] mm/vmscan: add page demotion counter Huang Ying
2021-06-18 6:15 ` [PATCH -V8 07/10] mm/vmscan: add helper for querying ability to age anonymous pages Huang Ying
2021-06-18 15:45 ` Zi Yan
2021-06-19 2:33 ` Huang, Ying
2021-06-18 6:15 ` [PATCH -V8 08/10] mm/vmscan: Consider anonymous pages without swap Huang Ying
2021-06-18 6:15 ` [PATCH -V8 09/10] mm/vmscan: never demote for memcg reclaim Huang Ying
2021-06-18 6:15 ` [PATCH -V8 10/10] mm/migrate: add sysfs interface to enable reclaim migration Huang Ying
2021-06-22 9:00 ` [PATCH -V8 00/10] Migrate Pages in lieu of discard Oscar Salvador
2021-06-23 1:12 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36307d7a-6e39-b1dd-64e8-95ec59f16867@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shy828301@gmail.com \
--cc=weixugc@google.com \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®