From: David Howells <dhowells@redhat.com>
To: Imre Deak <imre.deak@intel.com>
Cc: dhowells@redhat.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Dave Jones <davej@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Lukas Czerner <lczerner@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wait: fix false timeouts when using wait_event_timeout()
Date: Thu, 02 May 2013 13:29:44 +0100 [thread overview]
Message-ID: <3633.1367497784@warthog.procyon.org.uk> (raw)
In-Reply-To: <1367485129-4423-1-git-send-email-imre.deak@intel.com>
Imre Deak <imre.deak@intel.com> wrote:
> Many callers of the wait_event_timeout() and
> wait_event_interruptible_timeout() expect that the return value will be
> positive if the specified condition becomes true before the timeout
> elapses. However, at the moment this isn't guaranteed. If the wake-up
> handler is delayed enough, the time remaining until timeout will be
> calculated as 0 - and passed back as a return value - even if the
> condition became true before the timeout has passed.
>
> Fix this by returning at least 1 if the condition becomes true. This
> semantic is in line with what wait_for_condition_timeout() does; see
> commit bb10ed09 - "sched: fix wait_for_completion_timeout() spurious
> failure under heavy load".
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2013-05-02 12:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 8:58 Imre Deak
2013-05-02 9:36 ` Daniel Vetter
2013-05-07 23:12 ` Andrew Morton
2013-05-08 9:49 ` Imre Deak
2013-05-02 10:29 ` David Howells
2013-05-02 12:02 ` Imre Deak
2013-05-02 12:13 ` Daniel Vetter
2013-05-02 12:23 ` Jens Axboe
2013-05-02 12:34 ` Imre Deak
2013-05-02 12:54 ` Jens Axboe
2013-05-02 13:56 ` Imre Deak
2013-05-02 14:04 ` Daniel Vetter
2013-05-02 12:29 ` David Howells
2013-05-02 12:29 ` David Howells [this message]
2013-05-02 12:35 ` Jens Axboe
2013-05-02 19:56 ` Imre Deak
2013-06-04 19:28 Oleg Nesterov
2013-06-04 21:35 ` Imre Deak
2013-06-04 21:40 ` Imre Deak
2013-06-05 16:37 ` Oleg Nesterov
2013-06-05 19:07 ` Oleg Nesterov
2013-06-06 1:45 ` Tejun Heo
2013-06-06 18:47 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3633.1367497784@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=daniel.vetter@ffwll.ch \
--cc=davej@redhat.com \
--cc=imre.deak@intel.com \
--cc=lczerner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome