From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965135AbdADRgi (ORCPT ); Wed, 4 Jan 2017 12:36:38 -0500 Received: from foss.arm.com ([217.140.101.70]:55122 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934887AbdADRgB (ORCPT ); Wed, 4 Jan 2017 12:36:01 -0500 Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is disabled To: Jiri Olsa References: <1483537960-14499-1-git-send-email-sudeep.holla@arm.com> <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> <20170104160654.GA11619@krava> <1f976b40-608e-412c-910c-6b0e078a8ae0@arm.com> <20170104171955.GA21024@krava> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Jiri Olsa From: Sudeep Holla Organization: ARM Message-ID: <3634d760-c2de-f73d-0a54-afa5b19489ed@arm.com> Date: Wed, 4 Jan 2017 17:26:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104171955.GA21024@krava> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/17 17:19, Jiri Olsa wrote: > On Wed, Jan 04, 2017 at 04:18:10PM +0000, Sudeep Holla wrote: >> >> >> On 04/01/17 16:08, Sudeep Holla wrote: >>> >>> >>> On 04/01/17 16:06, Jiri Olsa wrote: >>>> On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote: >>>>> When libelf is disabled in the configuration, we get the following >>>>> linker error: >>>>> LINK libperf-jvmti.so >>>>> ld: cannot find -lelf >>>>> Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed >>>>> >>>>> Jiri pointed out that both librt and libelf are not really required. So >>>>> this patch fixes the linker error by getting rid of unwanted libraries >>>>> in the linker stage. >>>>> >>>>> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build") >>>> >>>> hum, AFAICS it linked -lelf and -lrt even before right? ;-) >>>> >>> >>> Yes, sorry I forgot to remove that and trace it back the actual commit. >>> >> >> Having looked at it again, it looks new additions in the above commit. >> It may be a copied from somewhere else but I can't trace it back :(. >> I need your help if you want to get rid of that ;) > > I think it's this one: > 209045adc2bb perf tools: add JVMTI agent library Thanks for that, I would never have figured this out myself. Will fix that and send out v3. -- Regards, Sudeep