From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152B1C433FF for ; Fri, 2 Aug 2019 16:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6B5720449 for ; Fri, 2 Aug 2019 16:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390376AbfHBQQL (ORCPT ); Fri, 2 Aug 2019 12:16:11 -0400 Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:36721 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728853AbfHBQQK (ORCPT ); Fri, 2 Aug 2019 12:16:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 432EA181D3419; Fri, 2 Aug 2019 16:16:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: dad84_52659459e0a12 X-Filterd-Recvd-Size: 2820 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Fri, 2 Aug 2019 16:16:06 +0000 (UTC) Message-ID: <36351fc3177bce273ecf47dd00b013306026aa2c.camel@perches.com> Subject: Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use From: Joe Perches To: Kees Cook , Pavel Machek Cc: Neil Horman , Miguel Ojeda , "H. Peter Anvin" , Peter Zijlstra , Linus Torvalds , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "Gustavo A . R . Silva" , Arnaldo Carvalho de Melo , Kan Liang , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Shawn Landden , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , linux-kernel Date: Fri, 02 Aug 2019 09:16:04 -0700 In-Reply-To: <201908020907.4E056142@keescook> References: <765E740C-4259-4835-A58D-432006628BAC@zytor.com> <20190731184832.GZ31381@hirez.programming.kicks-ass.net> <20190801122429.GY31398@hirez.programming.kicks-ass.net> <0BCDEED9-0B72-4412-909F-76C20D54983E@zytor.com> <20190802110042.GA6957@hmswarspite.think-freely.org> <20190802123418.GA3722@amd> <201908020907.4E056142@keescook> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-08-02 at 09:09 -0700, Kees Cook wrote: > On Fri, Aug 02, 2019 at 02:34:18PM +0200, Pavel Machek wrote: > > I like the "fallthrough". It looks like "return" and it should, no > > need to have __'s there.. > > Yeah, it would have the same feel as "break", "continue", "return"... > > The only place I see this already used is in net/sctp/sm_make_chunk.c, > as a label, which would be trivial to adjust... Yeah. >From the RFC patch: For allow compilation of a kernel that includes net/sctp, this patch also requires a rename of the use of fallthrough as a label in net/sctp/sm_make_chunk.c that was submitted as: https://lore.kernel.org/lkml/e0dd3af448e38e342c1ac6e7c0c802696eb77fd6.1564549413.git.joe@perches.com/