From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbcGFNS4 (ORCPT ); Wed, 6 Jul 2016 09:18:56 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:52335 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbcGFNSy (ORCPT ); Wed, 6 Jul 2016 09:18:54 -0400 From: Arnd Bergmann To: Neil Armstrong Cc: "moderated list:ARM/OXNAS platfor..." , Linux Kernel Mailing List Subject: Re: [PATCH] oxnas: select reset controller framework Date: Wed, 06 Jul 2016 15:21:40 +0200 Message-ID: <3635781.NJKnVkuV7s@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <20160706124826.1563413-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7Dw5A9QE5UXuo+5C8G/fHnofoSrz9x+dD8Od9v6Cly7eE4rmaLB vGdCQ04q/0yKX0X0jH5oELGYSxWfChv93m0isG5WnfwOxTAYIrMxpPHRKFQWIpA8fbpxVne 2neUMldYtl7uQ7BDc1SbGNiMTR2x+ZrM/YZZiOa4EJIQT4dMd3W2kPOvcQAxBPThA687cib kpKN0PfztNGymzdjn48kA== X-UI-Out-Filterresults: notjunk:1;V01:K0:iZ2Ru3XW774=:S0qMJEPPoc7BAw4G3UBqZl j2FQj4Vlky68YhmqXrTbVda+yP9Qzcenr9UIC5VyuoykRGjhHSrKuaxfXF0WWJ03KBoQ1Md4w Wm6ymX8rBnqDQyn/DZa1UbOJA6bDkFUjJEMbKZIQ/onJqMj23sW9Ghm5NWGzNPlH+Nzuo4avk /+mopUh5VAz0rzs79HDI95g31PhF8iTxkYKePWtheJEv/NfSfmjKcjwiEkFUbAF+fWY8tSW5l 53lKwv1aLFrSbpcowk0DTN6FjEWXnDU4Xan9upisMy7/NF/930ia94WOrPwr/adBxANa4VDeF 7VCNmQKkV8DrJ59jiN+6J+CnHLGBnXt4xxqvvJCTAodo74nBI8JSG24E8NJVqXsPjdq3Uvdzh 5xv7Wbs+34V60TgqBSsyVH8e2TC+8ejcEFKJFhE+H7HYwC9DOjZWRCa9btf1BQejAgMUHi3O5 qs1yuGAT75Whcw100452AvcHkmM1xuAcI6ko/NxVylE1Bdfcsop+tfnh0IvICOP/orsOrDAY7 SHuXtczsQZzuNldFfISJjeHaPW3zE0N6eGGxCYyFh6haL8w7MvOZ07z5Isljy1c5MXg+i5hKW JucTY7zgQ/N3Cm8sNzMau+LLoj3sHZgQEPpDvQWoYetcEuG6SLJJH6i/UFLHAeUo36vvbpkXb NvW+4Ztk+tZY2k/W4wQp8Zva+EvSEjzMWdpmPSArkor8I9HCm8Pm8eoQ+R5G87xom1Q+TKfxh qV6rXU6qcHA7H9dJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 6, 2016 3:04:25 PM CEST Neil Armstrong wrote: > 2016-07-06 14:48 GMT+02:00 Arnd Bergmann : > > For unknown reasons, we have to enable three symbols for a platform > > to use a reset controller driver, otherwise we get a Kconfig > > warning: > > > > warning: (MACH_OX810SE) selects RESET_OXNAS which has unmet direct dependencies (RESET_CONTROLLER) > > > > This selects the other two symbols for oxnas. > > > > Signed-off-by: Arnd Bergmann > > --- > > arch/arm/mach-oxnas/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-oxnas/Kconfig b/arch/arm/mach-oxnas/Kconfig > > index 2dde0acf01fd..b6a36d660e6f 100644 > > --- a/arch/arm/mach-oxnas/Kconfig > > +++ b/arch/arm/mach-oxnas/Kconfig > > @@ -11,11 +11,13 @@ if ARCH_OXNAS > > > > config MACH_OX810SE > > bool "Support OX810SE Based Products" > > + select ARCH_HAS_RESET_CONTROLLER > > This is strange since this is selected by CONFIG_ARCH_OXNAS ! > You are right, this one is not needed. > > select ARM_TIMER_SP8 > > select COMMON_CLK_OXNAS > > select CPU_ARM926T > > select MFD_SYSCON > > select PINCTRL_OXNAS > > + select RESET_CONTROLLER > > Same here, it should be selected by ARCH_HAS_RESET_CONTROLLER I actually did a patch at one point to kill off ARCH_HAS_RESET_CONTROLLER completely, it's not really needed at all, but that is a larger rework so (I think) I never submitted it. Arnd