Re: [PATCH 2/3] arm64: dts: qcom: Rework X1-based Asus Zenbook A14's displays

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/23/25 9:21 PM, Aleksandrs Vinarskis wrote:
> 
> 
> 
> 
> 
> On Friday, September 12th, 2025 at 18:52, Aleksandrs Vinarskis <alex@vinarskis.com> wrote:
> 
>>
>>
>>
>>
>>
>>
>>
>> On Friday, September 12th, 2025 at 12:44, Konrad Dybcio konrad.dybcio@oss.qualcomm.com wrote:
>>
>>> On 9/8/25 8:45 PM, Aleksandrs Vinarskis wrote:
>>>
>>>> The laptop comes in two variants:
>>>>
>>>> * UX3407RA, higher end, FHD+ OLED or WOXGA+ OLED panels
>>>> * UX3407QA, lower end, FHD+ OLED or FHD+ LCD panels
>>>>
>>>> Even though all three panels work with "edp-panel", unfortunately the
>>>> brightness adjustmenet of LCD panel is PWM based, requiring a dedicated
>>>> device-tree. Convert "x1p42100-asus-zenbook-a14.dts" into ".dtsi" to
>>>> allow for this split, introduce new LCD variant. Leave current variant
>>>> without postfix and with the unchanged model name, as some distros
>>>> (eg. Ubuntu) rely on this for automatic device-tree detection during
>>>> kernel installation/upgrade.
>>>>
>>>> As dedicated device-tree is required, update compatibles of OLED
>>>> variants to correct ones. Keep "edp-panel" as fallback, since it is
>>>> enough to make the panels work.
>>>>
>>>> Signed-off-by: Aleksandrs Vinarskis alex@vinarskis.com
>>>> Co-developed-by: Jens Glathe jens.glathe@oldschoolsolutions.biz
>>>> Signed-off-by: Jens Glathe jens.glathe@oldschoolsolutions.biz
>>>> ---
>>>
>>> [...]
>>>
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtsi
>>>> @@ -0,0 +1,141 @@
>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>> +/*
>>>> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
>>>> + * Copyright (c) 2025 Aleksandrs Vinarskis alex@vinarskis.com
>>>> + */
>>>> +
>>>> +/dts-v1/;
>>>> +
>>>> +#include "x1p42100.dtsi"
>>>> +#include "x1-asus-zenbook-a14.dtsi"
>>>> +
>>>> +/delete-node/ &pmc8380_6;
>>>> +/delete-node/ &pmc8380_6_thermal;
>>>> +
>>>> +/ {
>>>> + model = "ASUS Zenbook A14 (UX3407QA)";
>>>
>>> 'model' in .dtsi is 'eeeeh'
>>
>>
>> Followed example of Thinkpad t14s and CRD, as they set it to
>> 'default' in .dtsi, and overwrite in .dts. Could fix it starting
>> with Zenbook here, but in this case probably makes sense to also
>> drop 'model' from higher level 'x1-asus-zenbook-a14.dtsi' as well?
> 
> Hi Konrad,
> 
> Any comments on this?
> 
> Alex

Yes, ultimately model and compatible should be in .dts only

Konrad