From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754513AbcGFNRI (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 09:17:08 -0400
Received: from mout.kundenserver.de ([212.227.126.133]:58888 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753516AbcGFNRF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 09:17:05 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx21: include linux/module.h
Date: Wed, 06 Jul 2016 15:20:04 +0200
Message-ID: <3638123.Y5hU8jV7GH@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAOMZO5APrVUAi+QbnLVJ61T_oJRQQDF_eLi8_HeqK=L+aVBzwQ@mail.gmail.com>
References: <20160706125254.1663066-1-arnd@arndb.de> <CAOMZO5APrVUAi+QbnLVJ61T_oJRQQDF_eLi8_HeqK=L+aVBzwQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:tdg06YN34TOE/CEPBeio8W+LNglVryTbBLC5i+qps9qxwIirdq+
 mfwRf2tDv9+Kn/jZjKAnmIfVLB7KGqn2qAcwyR/XatWlTTuCyPiWQ+o+VXcrSWzlmGosxYA
 Hv6E/gsxYVVMEAr0O2eoyFPMadW/i1UkLe8nEk0cOUiY9mmjOmHSjZtMlcgYKr89gAlng2s
 VZ6JRbcA1dJAvFyB4vmVA==
X-UI-Out-Filterresults: notjunk:1;V01:K0://FpAgi1Ty0=:Zy5wuglsxo58P2ze24OCxV
 XEVdrn6s7FZec6CU6JbeUQ6CY0plBFEJnj1B/xDBP2vbgUaiABwSCrkcZ347bIqryzpoc58O0
 2ms8LPqSPIULWl842uGJN1QxY2dXKHl2xYqo31POOFjR6QbrwtTflzK5hF+q7qRi9HBhfh/P8
 SjHwM5q05ppTVMXaEE1yJsQ6T4F+hB4CF2KOEH7b22XkJv0TYA10RWuNQt/ZmV7B88gRNcNXA
 857xuuE1aZc5kNvsA3Bc5R7KFWgmmxz8kqfrhpEfSschgAprmYC2GNCFiIVuUB1mQ/YAV/9K+
 C9DZemijiV1O9jzucCUtd3uj+a+XsW/ekjkc6D6vPKTGpeqmDGxqTIY/wJ0Q8jxrhtDzP0WnD
 WfwPLs4dVsgIA1SIFwwo0ebvWu5E0ImKg3spxz1mHwoHNIhSOsRfzcmH19cyP2LKGd+VaZnDr
 nLY1pek+AquDPsIwQ3eHMy1Q+ZcRMxp4emys6bVmcX4d8YTM44PeDgQvBalLbwCc5HDrN9oL9
 0E+x2bWmB4/ACZqTMHccvSPOtAwQFTV9v1GWuGLSGo5qyjRkJS7G0K0CA9qgdcBTvzDQW7Ke1
 81y5B2NpwrOcFLfk3clGYLE91+J1BGLhDld59WJsAqsrjKIwUDZfkwCdqUGKcvmRj5RcGmq/b
 7lwHqSUCEyZPXcP2+smTVbQ3KDuUactgs7Kr1ezxVowf60keUFSZ8Ao8FwsNq5/27OLO1hOB3
 nOBnOkMNBNkLNNdf
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, July 6, 2016 10:15:41 AM CEST Fabio Estevam wrote:
> I think the correct fix here would be:
> 
> --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] =
>         { .compatible = "fsl,imx21-iomuxc", },
>         { }
>  };
> -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> 
>  static struct platform_driver imx21_pinctrl_driver = {
>         .driver = {
> 
> 
> If you agree I can send a formal patch.

Fine with me too.

	Arnd