From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864AbcBURny (ORCPT ); Sun, 21 Feb 2016 12:43:54 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:59926 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751106AbcBURnw (ORCPT ); Sun, 21 Feb 2016 12:43:52 -0500 From: "Rafael J. Wysocki" To: Eric Biggers Cc: linux-pm@vger.kernel.org, pavel@ucw.cz, len.brown@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PM: declare __tracedata symbols as char[] rather than char Date: Sun, 21 Feb 2016 14:45:20 +0100 Message-ID: <3639816.6c6FK9gNMm@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453687732-1602-1-git-send-email-ebiggers3@gmail.com> References: <1453687732-1602-1-git-send-email-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, January 24, 2016 08:08:52 PM Eric Biggers wrote: > Accessing more than one byte from a symbol declared simply 'char' is undefined > behavior, as reported by UBSAN: > > UBSAN: Undefined behaviour in drivers/base/power/trace.c:178:18 > load of address ffffffff8203fc78 with insufficient space > for an object of type 'char' > > Avoid this by declaring the symbols as arrays. > > Signed-off-by: Eric Biggers Queued up for 4.6, thanks! Rafael