From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980A4C433F5 for ; Mon, 14 Feb 2022 08:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241550AbiBNID1 convert rfc822-to-8bit (ORCPT ); Mon, 14 Feb 2022 03:03:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233043AbiBNIDZ (ORCPT ); Mon, 14 Feb 2022 03:03:25 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 858DD5B3CB for ; Mon, 14 Feb 2022 00:03:16 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJWKA-0006vg-Ok; Mon, 14 Feb 2022 09:03:06 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Greg Kroah-Hartman , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Yong Wu Cc: James Wang , Liviu Dudau , iommu@lists.linux-foundation.org, Matthias Brugger , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Joerg Roedel , Will Deacon , Arnd Bergmann , Laurent Pinchart , linux-mediatek@lists.infradead.org, Chun-Kuang Hu , linux-arm-kernel@lists.infradead.org, Stephen Boyd , AngeloGioacchino Del Regno , Hsin-Yi Wang , Robin Murphy , Tomasz Figa , srv_heupstream@mediatek.com, Rob Clark , Srinivas Kandagatla , Sebastian Reichel , Yong Wu , Sandy Huang , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 13/23] drm/rockchip: Make use of the helper component_compare_dev Date: Mon, 14 Feb 2022 09:03:04 +0100 Message-ID: <3640952.nfqboWGjmy@diego> In-Reply-To: <20220214060819.7334-14-yong.wu@mediatek.com> References: <20220214060819.7334-1-yong.wu@mediatek.com> <20220214060819.7334-14-yong.wu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 14. Februar 2022, 07:08:09 CET schrieb Yong Wu: > Use the common compare helper from component. > > Cc: Sandy Huang > Cc: "Heiko St¨¹bner" > Cc: linux-rockchip@lists.infradead.org > Signed-off-by: Yong Wu Acked-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index bec207de4544..3c2f2d6ecc36 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -290,11 +290,6 @@ int rockchip_drm_endpoint_is_subdriver(struct device_node *ep) > return false; > } > > -static int compare_dev(struct device *dev, void *data) > -{ > - return dev == (struct device *)data; > -} > - > static void rockchip_drm_match_remove(struct device *dev) > { > struct device_link *link; > @@ -321,7 +316,7 @@ static struct component_match *rockchip_drm_match_add(struct device *dev) > break; > > device_link_add(dev, d, DL_FLAG_STATELESS); > - component_match_add(dev, &match, compare_dev, d); > + component_match_add(dev, &match, component_compare_dev, d); > } while (true); > } > >