mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Venkat Subbiah" <venkats@cranite.com>
To: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
Cc: "Chris Snook" <csnook@redhat.com>, <linux-kernel@vger.kernel.org>
Subject: RE: irq load balancing
Date: Thu, 13 Sep 2007 14:02:15 -0700	[thread overview]
Message-ID: <3641F7C576757E49AE23AD0D820D72C434DCB8@mailnode1.cranite.com> (raw)
In-Reply-To: <20070913204443.GB5386@csclub.uwaterloo.ca>

Since most network devices have a single status register for both
receiver and transmit (and errors and the like), which needs a lock to
protect access, you will likely end up with serious thrashing of moving
the lock between cpus.
> Any ways to measure the trashing of locks?

Since most network devices have a single status register for both
receiver and transmit (and errors and the like)
> These register accesses will be mostly within the irq handler which I
plan on keeping on the same processor. The network driver is actually
tg3. Will looks closely into the driver.

Thx,
Venkat


-----Original Message-----
From: Lennart Sorensen [mailto:lsorense@csclub.uwaterloo.ca] 
Sent: Thursday, September 13, 2007 1:45 PM
To: Venkat Subbiah
Cc: Chris Snook; linux-kernel@vger.kernel.org
Subject: Re: irq load balancing

On Thu, Sep 13, 2007 at 01:31:39PM -0700, Venkat Subbiah wrote:
> Doing it in a round-robin fashion will be disastrous for performance.
> Your cache miss rate will go through the roof and you'll hit the slow
> paths in the network stack most of the time.
> > Most of the work in my system is spent in enrypt/decrypting traffic.
> Right now all this is done in a tasklet within the softirqd and hence
> all landing up on the same CPU.
> On the receive side it'a packet handler that handles the traffic. On
the
> tx side it's done within the transmit path of the packet. So would
> re-architecting this to move the rx packet handler to a different
kernel
> thread(with smp affinity to one CPU) and tx to a different kernel
> thread(with SMP affinity to a different CPU) be advisable. 
> What's the impact on cache miss and slowpath/fastpath in network
stack.

Since most network devices have a single status register for both
receiver and transmit (and errors and the like), which needs a lock to
protect access, you will likely end up with serious thrashing of moving
the lock between cpus.

--
Len Sorensen

  reply	other threads:[~2007-09-13 21:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-11 23:18 Venkat Subbiah
2007-09-12 11:51 ` Stephen Hemminger
2007-09-12 11:55 ` kalash nainwal
2007-09-12 14:47 ` Arjan van de Ven
2007-09-12 21:44 ` Chris Snook
2007-09-13 20:31   ` Venkat Subbiah
2007-09-13 20:44     ` Lennart Sorensen
2007-09-13 21:02       ` Venkat Subbiah [this message]
2007-09-13 21:30         ` Chris Snook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3641F7C576757E49AE23AD0D820D72C434DCB8@mailnode1.cranite.com \
    --to=venkats@cranite.com \
    --cc=csnook@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsorense@csclub.uwaterloo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®