From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760492AbcIXIo3 (ORCPT ); Sat, 24 Sep 2016 04:44:29 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:55425 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbcIXIoX (ORCPT ); Sat, 24 Sep 2016 04:44:23 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: maximlevitsky@gmail.com, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] memstick: r592: add function declaration Date: Sat, 24 Sep 2016 10:38:50 +0200 Message-ID: <3643004.RcSUHOLt46@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474695146-3113-1-git-send-email-baoyou.xie@linaro.org> References: <1474695146-3113-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:sJclWMvKvEc0cZAVwcvb1k3ICqM9xOV+jDRHq59g0cn1Q1QyyQR oY1Y1F3+LlJtIYaW4dO7gnwETdgLjWo+xeR4gESIODIk91dAegmRTtaLuiierYp3OTvakYs r7w2XNImRDvnKb5mK6t28rYA8hFSOH9RN0mrnQMkB1jrGk9J5pG/f844IKVm8KdmGYGOud8 9GUZiEKnk/KeDTPTv0z3Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:Pme09JX/VkU=:r79qjuBwwJSndvCJVof3Ec zsV1hQW762O8de/2T/oCbAGaQN/eA8/WcRZsWbvSqF7yv91HbJMd4NC/ep3LjOCVmHhL5JpiT xdONHi0+BzqlynmbcJ9Iiq1jsKysQcMcZS3ZWbTrzNMgZK/KXBOOL/6VrFYtqH50NAZhmFD1E FEdpT7QDA/J5YWnHAQ5cp9fmA9ZAQwYqnZ2S6bMV0EK4iF3MoByPEJbOgEEwEBCc/Q+2qQfF8 iKtTonZgx2JjSphaMINO4DbjRu0SVT4XohZTznjn6g9rc5x7FMLGUCv6iJna6ghNBfKfCIBgj ZEGRHm+vpfh+qIaWQtYB+N1BuRktxfuySnAgnKxm7N28PMh53itmsZjYJ5ApQIP68IVXsnhnZ YxZ9yFFxMGSFa/crH5cN5RUpAPQfbkwJ30VkgJ9sKwGapj+N+2FLlclPY56zH20v42kLvUP5o V/iCGWIPjm/vTajWIYtjtWRvWhLoqSdh31JIcAvxk1rAbl8yHXV4Mf9XWwp/S2lx/60cLSVgE nFl8P6+yPB7JoThKApiuv54MOFbCi4YgDOwjPjWgegKWdYyNLIJbUJf2eCVlOBfnen30c+FAt nXYS26iNwxTlYsldpAkx9XeGYtmITHFNdSCU2Ujg30tH5+K4434olMjmV/KWMq8wxErn+aA4C ks30LN6F4Z2Zm8DU5qH1jrFBh7mrZukg2PaRy/wszZrIpIqQqUTKTH0G+Qls4NtM+e8iih/nb 4s2QEL9Ak8n0syu2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, September 24, 2016 1:32:26 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/memstick/host/r592.c:50:13: warning: no previous prototype for 'memstick_debug_get_tpc_name' [-Wmissing-prototypes] > > In fact, this function need be declared in a header files. > > So this patch adds function declaration in > drivers/memstick/host/r592.h. > > Signed-off-by: Baoyou Xie > --- > drivers/memstick/host/r592.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/memstick/host/r592.h b/drivers/memstick/host/r592.h > index c5726c1..c5d91cd 100644 > --- a/drivers/memstick/host/r592.h > +++ b/drivers/memstick/host/r592.h > @@ -172,4 +172,6 @@ struct r592_device { > #define dbg_verbose(format, ...) __dbg(2, format, ## __VA_ARGS__) > #define dbg_reg(format, ...) __dbg(3, format, ## __VA_ARGS__) > > +const char *memstick_debug_get_tpc_name(int tpc); > + > #endif > This looks wrong too. I don't see this function serving any purpose, despite being exported. It may be intended to be used by kernel debuggers, but those should just look up the symbolic value of the enum memstick_tpc definition instead. Better just remove the function and the array above it. Arnd