mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Alexander.Kleinsorge@gmx.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: new module to check constant memory for corruption
Date: Sat, 12 Apr 2014 23:08:03 -0400	[thread overview]
Message-ID: <36478.1397358483@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 13 Apr 2014 03:33:10 +0200." <trinity-aef9715a-72d2-4824-a3d8-306d5850c633-1397352790457@3capp-gmx-bs18>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Sun, 13 Apr 2014 03:33:10 +0200, Alexander.Kleinsorge@gmx.de said:

> 		printk(KERN_EMERG MODNAME "error: const kernel memory is broken (%08lx != 0), please reboot!", g_SumLast);

Make a list of all the things that can dynamically modify kernel text while
it's running, starting with the alternatives code, and adding in the various
tracing and debugging tools, and ask yourself if KERN_EMERG is the right
choice here...

Also, that printk is in the wrong place - it only fires if somebody reads
the /proc file, and it *should* trigger as soon as practical after a
problem has been detected.

Bonus points for computing what percent of single, double, triple, and
other error syndromes your xor detects (hint - what is the behavior of a
dead row or column of bits?).

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

      parent reply	other threads:[~2014-04-13  3:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13  1:33 Alexander.Kleinsorge
2014-04-13  3:00 ` Andi Kleen
2014-04-13 10:14   ` Aw: " Alexander.Kleinsorge
2014-04-13 10:26     ` Richard Weinberger
     [not found]       ` <trinity-99a290b9-30fa-464e-b67b-b8555d48011b-1397406377024@3capp-gmx-bs45>
2014-04-13 16:43         ` Richard Weinberger
2014-04-14 14:14           ` Jiri Kosina
2014-04-13 17:20       ` Aw: Re: " Alexander.Kleinsorge
2014-04-13 15:55     ` Andi Kleen
2014-04-13 16:22       ` Aw: " Alexander.Kleinsorge
2014-04-14  8:03   ` Aw: " Alexander.Kleinsorge
2014-04-13  3:08 ` Valdis.Kletnieks [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36478.1397358483@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=Alexander.Kleinsorge@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®