From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754746AbdGTRt4 (ORCPT ); Thu, 20 Jul 2017 13:49:56 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:35670 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbdGTRtw (ORCPT ); Thu, 20 Jul 2017 13:49:52 -0400 Subject: Re: [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and finish To: "Rafael J. Wysocki" , Linux PM Cc: LKML References: <2539550.y54cRb749c@aspire.rjw.lan> <1528829.lXeqX43PVF@aspire.rjw.lan> <21457958.U8q3irAeUz@aspire.rjw.lan> From: Mark Salyzyn Message-ID: <364d0454-a446-51c4-f9c5-15bc6670928a@android.com> Date: Thu, 20 Jul 2017 10:49:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <21457958.U8q3irAeUz@aspire.rjw.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2017 06:38 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Regardless of whether or not debug messages from the core system > suspend/hibernation code are enabled, it is useful to know when > system-wide transitions start and finish (or fail), so print "info" > messages at these points. > > Signed-off-by: Rafael J. Wysocki > --- > > -> v2: Smiplified the messages as suggested by Mark. > > --- > kernel/power/hibernate.c | 5 +++++ > kernel/power/suspend.c | 2 ++ > 2 files changed, 7 insertions(+) > > Index: linux-pm/kernel/power/hibernate.c > =================================================================== > --- linux-pm.orig/kernel/power/hibernate.c > +++ linux-pm/kernel/power/hibernate.c > @@ -692,6 +692,7 @@ int hibernate(void) > goto Unlock; > } > > + pr_info("hibernation entry\n"); nit (minor): Many of the logs report a PM: prefix. Flipping coin that the 3 characters provides any real gain is in your hands. My WAG is it would be nice to be able to do dmesg | grep PM: Ack