From: Antonio Quartulli <antonio@openvpn.net>
To: netdev@vger.kernel.org
Cc: Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Shuah Khan <shuah@kernel.org>,
sd@queasysnail.net, ryazanov.s.a@gmail.com,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v12 12/22] ovpn: implement multi-peer support
Date: Thu, 5 Dec 2024 11:33:25 +0100 [thread overview]
Message-ID: <364f199c-8d8d-4228-bdd7-13ab81d10e39@openvpn.net> (raw)
In-Reply-To: <20241202-b4-ovpn-v12-12-239ff733bf97@openvpn.net>
On 02/12/2024 16:07, Antonio Quartulli wrote:
[...]
> +
> +/**
> + * ovpn_peer_unhash - remove peer reference from all hashtables
> + * @peer: the peer to remove
> + * @reason: the delete reason to attach to the peer
> + */
> +static void ovpn_peer_unhash(struct ovpn_peer *peer,
> + enum ovpn_del_peer_reason reason)
> +{
> + lockdep_assert_held(&peer->ovpn->lock);
> +
> + hlist_del_init_rcu(&peer->hash_entry_id);
> +
> + hlist_nulls_del_init_rcu(&peer->hash_entry_addr4);
> + hlist_nulls_del_init_rcu(&peer->hash_entry_addr6);
> + hlist_nulls_del_init_rcu(&peer->hash_entry_transp_addr);
> +
> + ovpn_peer_put(peer);
This put() should be dropped as we now call it in ovpn_peer_remove().
Will be fixed in v13.
Regards,
--
Antonio Quartulli
OpenVPN Inc.
next prev parent reply other threads:[~2024-12-05 10:32 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 15:07 [PATCH net-next v12 00/22] Introducing OpenVPN Data Channel Offload Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 01/22] net: introduce OpenVPN Data Channel Offload (ovpn) Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 02/22] ovpn: add basic netlink support Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 03/22] ovpn: add basic interface creation/destruction/management routines Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 04/22] ovpn: keep carrier always on for MP interfaces Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 05/22] ovpn: introduce the ovpn_peer object Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 06/22] ovpn: introduce the ovpn_socket object Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 07/22] ovpn: implement basic TX path (UDP) Antonio Quartulli
2024-12-03 14:55 ` Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 08/22] ovpn: implement basic RX " Antonio Quartulli
2024-12-03 14:34 ` Paolo Abeni
2024-12-03 14:38 ` Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 09/22] ovpn: implement packet processing Antonio Quartulli
2024-12-03 14:58 ` Paolo Abeni
2024-12-03 15:04 ` Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 10/22] ovpn: store tunnel and transport statistics Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 11/22] ovpn: implement TCP transport Antonio Quartulli
2024-12-03 15:19 ` Paolo Abeni
2024-12-04 11:15 ` Antonio Quartulli
2024-12-04 21:37 ` Antonio Quartulli
2024-12-04 22:52 ` Antonio Quartulli
2024-12-04 23:09 ` Antonio Quartulli
2024-12-09 10:46 ` Matthieu Baerts
2024-12-09 10:58 ` Antonio Quartulli
2024-12-09 11:31 ` Matthieu Baerts
2024-12-09 14:08 ` Antonio Quartulli
2024-12-09 16:26 ` Matthieu Baerts
2024-12-02 15:07 ` [PATCH net-next v12 12/22] ovpn: implement multi-peer support Antonio Quartulli
2024-12-05 10:33 ` Antonio Quartulli [this message]
2024-12-02 15:07 ` [PATCH net-next v12 13/22] ovpn: implement peer lookup logic Antonio Quartulli
2024-12-03 14:58 ` Antonio Quartulli
2024-12-03 16:09 ` Sabrina Dubroca
2024-12-04 8:28 ` Antonio Quartulli
2024-12-04 14:13 ` Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 14/22] ovpn: implement keepalive mechanism Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 15/22] ovpn: add support for updating local UDP endpoint Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 16/22] ovpn: add support for peer floating Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 17/22] ovpn: implement peer add/get/dump/delete via netlink Antonio Quartulli
2024-12-03 17:46 ` Paolo Abeni
2024-12-04 8:43 ` Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 18/22] ovpn: implement key add/get/del/swap " Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 19/22] ovpn: kill key and notify userspace in case of IV exhaustion Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 20/22] ovpn: notify userspace when a peer is deleted Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 21/22] ovpn: add basic ethtool support Antonio Quartulli
2024-12-02 15:07 ` [PATCH net-next v12 22/22] testing/selftests: add test tool and scripts for ovpn module Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364f199c-8d8d-4228-bdd7-13ab81d10e39@openvpn.net \
--to=antonio@openvpn.net \
--cc=andrew@lunn.ch \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sd@queasysnail.net \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®