From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-cachefs@redhat.com, David Howells <dhowells@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH] fscache: Replace four seq_puts() calls by seq_putc() in fscache_objlist_show()
Date: Sat, 6 May 2017 13:43:25 +0200 [thread overview]
Message-ID: <364f5283-8b2e-2f51-366e-f322655c3fa3@users.sourceforge.net> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 13:38:42 +0200
Four single characters should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/fscache/object-list.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c
index 67f940892ef8..3916db02623d 100644
--- a/fs/fscache/object-list.c
+++ b/fs/fscache/object-list.c
@@ -187,7 +187,7 @@ static int fscache_objlist_show(struct seq_file *m, void *v)
seq_puts(m, ", ");
if (config & FSCACHE_OBJLIST_CONFIG_AUX)
seq_puts(m, "AUX_DATA");
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
return 0;
}
@@ -198,7 +198,7 @@ static int fscache_objlist_show(struct seq_file *m, void *v)
if (config & (FSCACHE_OBJLIST_CONFIG_KEY |
FSCACHE_OBJLIST_CONFIG_AUX))
seq_puts(m, " ================");
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
return 0;
}
@@ -285,7 +285,7 @@ static int fscache_objlist_show(struct seq_file *m, void *v)
fscache_unuse_cookie(obj);
if (keylen > 0 || auxlen > 0) {
- seq_puts(m, " ");
+ seq_putc(m, ' ');
for (p = buf; keylen > 0; keylen--)
seq_printf(m, "%02x", *p++);
if (auxlen > 0) {
@@ -296,7 +296,7 @@ static int fscache_objlist_show(struct seq_file *m, void *v)
}
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
} else {
seq_puts(m, "<no_netfs>\n");
}
--
2.12.2
reply other threads:[~2017-05-06 11:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364f5283-8b2e-2f51-366e-f322655c3fa3@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®